Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable luis reference in composer #945

Closed
DingmaomaoBJTU opened this issue Sep 25, 2019 · 4 comments
Closed

Enable luis reference in composer #945

DingmaomaoBJTU opened this issue Sep 25, 2019 · 4 comments
Assignees
Labels
Area: LU Belongs to LU feature area R8 Release 8 - March 16th, 2020

Comments

@DingmaomaoBJTU
Copy link

DingmaomaoBJTU commented Sep 25, 2019

Version

What version of the Emulator are you using.

Describe the bug

To support managed LU interruption scenario, luis reference support are needed:

## Interruptions
- [AcceptEventEntry intent](../Main/Main.lu#AcceptEventEntry)
- [ChangeCalendarEntry intent](../Main/Main.lu#ChangeCalendarEntry)
- [CheckAvailability intent](../Main/Main.lu#CheckAvailability)
- [ConnectToMeeting intent](../Main/Main.lu#ConnectToMeeting)
- [CreateCalendarEntry intent](../Main/Main.lu#CreateCalendarEntry)
- [DeleteCalendarEntry intent](../Main/Main.lu#DeleteCalendarEntry)
- [Time Remaining intent](../Main/Main.lu#TimeRemaining)

With current ludown, composer cannot recognize luis intent reference for now. Please ensure this scenario can be supported with bf-luis.

image

@DingmaomaoBJTU DingmaomaoBJTU added Type: Bug Something isn't working Needs-triage A new issue that require triage labels Sep 25, 2019
@boydc2014
Copy link
Contributor

@DingmaomaoBJTU this would be enabled by 2 effort

  1. we replace ludown with bf-luis Replace ludown with bf-luis #944
  2. we use the new parser there supposed to be able to take a cusmoized import\resource resolve, so that we don't really depends very much to running the tool in certain folder.

@hibrenda hibrenda removed the Needs-triage A new issue that require triage label Sep 26, 2019
@yochay
Copy link
Contributor

yochay commented Sep 27, 2019

FYI @vishwacsena

@vishwacsena vishwacsena added the Area: LU Belongs to LU feature area label Oct 2, 2019
@vishwacsena
Copy link
Contributor

Tagging with LU label.

Discussed this with @boydc2014 - the ignite solution is for composer to switch to using the bf-cli library for the LU parser. In the BF CLI,

  • We are adding support for delegate based parsing. This will light up two scenarios:
    • General include references (like LG)
    • Cross training references (like this bug)
  • We will add a suggestModel API that can do the required cross training

@hibrenda hibrenda added Type: Enhancement and removed Type: Bug Something isn't working labels Oct 23, 2019
@hibrenda hibrenda added the R8 Release 8 - March 16th, 2020 label Dec 16, 2019
@hibrenda
Copy link
Contributor

addressed in #1608

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: LU Belongs to LU feature area R8 Release 8 - March 16th, 2020
Projects
None yet
Development

No branches or pull requests

6 participants