From 4e517b0c43e16dd2a91dccda7b53181a4d5751e8 Mon Sep 17 00:00:00 2001
From: liweitian <liweitian93@outlook.com>
Date: Sun, 8 Mar 2020 22:17:42 +0800
Subject: [PATCH 1/3] fix issue 2143 add title to form and visual iframe

---
 Composer/packages/client/src/pages/design/index.tsx | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/Composer/packages/client/src/pages/design/index.tsx b/Composer/packages/client/src/pages/design/index.tsx
index 25655f874f..2f3a935434 100644
--- a/Composer/packages/client/src/pages/design/index.tsx
+++ b/Composer/packages/client/src/pages/design/index.tsx
@@ -389,6 +389,7 @@ function DesignPage(props) {
                     hidden={triggerButtonVisible || !selected}
                     src={`${rootPath}/extensionContainer.html`}
                     ref={addRef}
+                    title={'visual editor'}
                   />
                   {!selected && onRenderBlankVisual(triggerButtonVisible, openNewTriggerModal)}
                 </div>
@@ -397,6 +398,7 @@ function DesignPage(props) {
                   name="FormEditor"
                   css={formEditor}
                   src={`${rootPath}/extensionContainer.html`}
+                  title={'form editor'}
                 />
               </div>
             </Fragment>

From efe03a0bb37a0495d3ade4dc6e425abf3dac993a Mon Sep 17 00:00:00 2001
From: liweitian <liweitian93@outlook.com>
Date: Sun, 8 Mar 2020 23:24:44 +0800
Subject: [PATCH 2/3] update text

---
 Composer/packages/client/src/pages/design/index.tsx | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/Composer/packages/client/src/pages/design/index.tsx b/Composer/packages/client/src/pages/design/index.tsx
index 2f3a935434..4252e307c0 100644
--- a/Composer/packages/client/src/pages/design/index.tsx
+++ b/Composer/packages/client/src/pages/design/index.tsx
@@ -389,7 +389,7 @@ function DesignPage(props) {
                     hidden={triggerButtonVisible || !selected}
                     src={`${rootPath}/extensionContainer.html`}
                     ref={addRef}
-                    title={'visual editor'}
+                    title={formatMessage('visual editor')}
                   />
                   {!selected && onRenderBlankVisual(triggerButtonVisible, openNewTriggerModal)}
                 </div>
@@ -398,7 +398,7 @@ function DesignPage(props) {
                   name="FormEditor"
                   css={formEditor}
                   src={`${rootPath}/extensionContainer.html`}
-                  title={'form editor'}
+                  title={formatMessage('form editor')}
                 />
               </div>
             </Fragment>

From dec0da382160c5eda77ea77e8028b5670afa6d46 Mon Sep 17 00:00:00 2001
From: liweitian <liweitian93@outlook.com>
Date: Sun, 8 Mar 2020 23:37:55 +0800
Subject: [PATCH 3/3] fix accessibility issue 2123 update ariaLabel text

---
 .../src/pages/notifications/NotificationHeader.tsx     | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/Composer/packages/client/src/pages/notifications/NotificationHeader.tsx b/Composer/packages/client/src/pages/notifications/NotificationHeader.tsx
index 5287df0a5c..2e67999ae5 100644
--- a/Composer/packages/client/src/pages/notifications/NotificationHeader.tsx
+++ b/Composer/packages/client/src/pages/notifications/NotificationHeader.tsx
@@ -11,10 +11,16 @@ import { notificationHeader, notificationHeaderText, dropdownStyles } from './st
 
 const createOptions = (): IDropdownOption[] => {
   const defaultOptions: IDropdownOption[] = [
-    { key: formatMessage('Show All Notifications'), text: formatMessage('All'), data: '', isSelected: true },
+    {
+      key: formatMessage('Show All Notifications'),
+      text: formatMessage('All'),
+      ariaLabel: formatMessage('Show All Notifications'),
+      data: '',
+      isSelected: true,
+    },
   ];
   DiagnosticSeverity.forEach(item => {
-    return defaultOptions.push({ key: item, text: item, data: item });
+    return defaultOptions.push({ key: item, text: item, data: item, ariaLabel: `Show ${item} Notifications` });
   });
   return defaultOptions;
 };