Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting empty string to language will throw an exception #2231

Closed
compulim opened this issue Jul 27, 2019 · 3 comments · Fixed by #2286
Closed

Setting empty string to language will throw an exception #2231

compulim opened this issue Jul 27, 2019 · 3 comments · Fixed by #2286
Assignees
Labels
bug Indicates an unexpected problem or an unintended behavior. front-burner

Comments

@compulim
Copy link
Contributor

compulim commented Jul 27, 2019

When using playground, the language prop passed to Web Chat is empty string instead of undefined, which caused Web Chat throw an exception.

@compulim compulim added bug Indicates an unexpected problem or an unintended behavior. Pending labels Jul 27, 2019
@cwhitten
Copy link
Member

Today WebChat will blow up if language = "", it should not blow up/

@compulim
Copy link
Contributor Author

compulim commented Aug 2, 2019

@corinagum did we fixed this in #2226?

Look at App.js:148

@corinagum
Copy link
Contributor

@compulim haha I thought you said that was a partial fix but I'm not sure what else needs to be done. One of us should test this on the Playground and report back

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Indicates an unexpected problem or an unintended behavior. front-burner
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants