Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Timestamp locale does not change when updating language on-the-fly #2360

Closed
compulim opened this issue Aug 27, 2019 · 1 comment · Fixed by #2414
Closed

Timestamp locale does not change when updating language on-the-fly #2360

compulim opened this issue Aug 27, 2019 · 1 comment · Fixed by #2414
Labels
backlog Out of scope for the current iteration but it will be evaluated in a future release. bug Indicates an unexpected problem or an unintended behavior. needs-repro Waiting for repro or investigation

Comments

@compulim
Copy link
Contributor

Screenshots

image

Version

master

Describe the bug

When locale prop is updated on-the-fly, the timestamp doesn't change accordingly.

To Reproduce

Steps to reproduce the behavior:

  1. Go to playground
  2. Send some messages
  3. Change the language to another one

Expected behavior

Timestamp is immediately localized in another language.

Actual, it is kept the same until page refresh.

Additional context

Playground is currently broke, change line 246 like below.

image

[Bug]
@compulim compulim added bug Indicates an unexpected problem or an unintended behavior. Pending labels Aug 27, 2019
@corinagum corinagum added Triage-E needs-repro Waiting for repro or investigation backlog Out of scope for the current iteration but it will be evaluated in a future release. and removed Pending labels Aug 27, 2019
@compulim compulim mentioned this issue Sep 22, 2019
Merged
1 task
@compulim compulim mentioned this issue Oct 25, 2019
Closed
55 tasks
@mohmed-elkhodry
Copy link

mohmed-elkhodry commented Jul 24, 2022 •
edited
Loading

@compulim
I face the same issue on version 4.15.2
is there any updates regarding this issue in this version ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
backlog Out of scope for the current iteration but it will be evaluated in a future release. bug Indicates an unexpected problem or an unintended behavior. needs-repro Waiting for repro or investigation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Language of timestamp should update on-the-fly compulim/BotFramework-WebChat
3 participants
@compulim @corinagum @mohmed-elkhodry