Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should interrupt speech synthesis after microphone button is clicked #2428

Closed
compulim opened this issue Sep 26, 2019 · 0 comments · Fixed by #2429
Closed

Should interrupt speech synthesis after microphone button is clicked #2428

compulim opened this issue Sep 26, 2019 · 0 comments · Fixed by #2429
Assignees
Labels
bug Indicates an unexpected problem or an unintended behavior.

Comments

@compulim
Copy link
Contributor

compulim commented Sep 26, 2019

Version

master

Describe the bug

This bug is discovered when speech recognition is enabled but speech synthesis is disabled.

Few points:

  • On the "core" side, we do not know if speech synthesis is going well or not, or if it is available on the system
  • We assumed if speech recognition is available, speech synthesis is also available
    • "core" will mark the next bot message to synthesize, if the user message was sending a message using a microphone
  • I believe we should think about whether part of speech should resides on "core", like today. Or we should move everything to "component"
    • "core" has no knowledge about the capability of the system, and should not have
    • Speech is a type of user interface, and "core" is for supporting the UI, should not dictate how a UI would work
    • If we move, we should be able to do the followings:
      • A way to force synthesizing of specific messages (a popular ask)
  • When Web Chat is synthesizing, it will not open microphone to prevent echo-ing back into itself
    • We used to stop synthesize when microphone is opened, we have a bug here not stopping synthesis
    • Microphone should have higher priority because microphone is an user interaction, while synthesize may not

To Reproduce

Steps to reproduce the behavior:

  1. Go to playground, or any speech-enabled Web Chat
  2. Click on microphone and say anything that the bot will respond
  3. While Web Chat is synthesizing the bot message, click on microphone button immediately

Expected behavior

Microphone should be turned on immediately, and synthesis is stopped. All messages that are pending synthesis will be stopped as well.

[Bug]

@compulim compulim added bug Indicates an unexpected problem or an unintended behavior. Pending labels Sep 26, 2019
@compulim compulim self-assigned this Sep 26, 2019
@compulim compulim mentioned this issue Oct 25, 2019
55 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Indicates an unexpected problem or an unintended behavior.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant