Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

es5 bundle needs ends-with package from corejs #2651

Closed
corinagum opened this issue Dec 2, 2019 · 0 comments · Fixed by #2654
Closed

es5 bundle needs ends-with package from corejs #2651

corinagum opened this issue Dec 2, 2019 · 0 comments · Fixed by #2654
Assignees
@corinagum
Labels
Bot Services Required for internal Azure reporting. Do not delete. Do not change color. bug Indicates an unexpected problem or an unintended behavior. customer-replied-to Required for internal reporting. Do not delete. customer-reported Required for internal Azure reporting. Do not delete.

Comments

@corinagum
Copy link
Contributor

Describe the bug

This bug was originally filed internally. IE11 fails and needs another polyfill

Fix: add https://github.com/zloirock/core-js/blob/master/packages/core-js/features/string/ends-with.js to index-es5.ts

[Bug]
@corinagum corinagum added bug Indicates an unexpected problem or an unintended behavior. Pending customer-reported Required for internal Azure reporting. Do not delete. Bot Services Required for internal Azure reporting. Do not delete. Do not change color. customer-replied-to Required for internal reporting. Do not delete. and removed Pending labels Dec 2, 2019
@corinagum corinagum self-assigned this Dec 2, 2019
@corinagum corinagum mentioned this issue Dec 3, 2019
Merged
1 task
@compulim compulim mentioned this issue Dec 10, 2019
Closed
73 tasks
@corinagum corinagum mentioned this issue Dec 13, 2019
Closed
73 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@corinagum corinagum

Labels
Bot Services Required for internal Azure reporting. Do not delete. Do not change color. bug Indicates an unexpected problem or an unintended behavior. customer-replied-to Required for internal reporting. Do not delete. customer-reported Required for internal Azure reporting. Do not delete.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update corejs modules corinagum/BotFramework-WebChat
1 participant
@corinagum