Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Missing tabindex on video player start button [accessibility] #3656

Closed
nfreear opened this issue Jan 7, 2021 · 3 comments
Closed

bug: Missing tabindex on video player start button [accessibility] #3656

nfreear opened this issue Jan 7, 2021 · 3 comments
Assignees
Labels
Bot Services Required for internal Azure reporting. Do not delete. Do not change color. bug Indicates an unexpected problem or an unintended behavior. customer-replied-to Required for internal reporting. Do not delete. customer-reported Required for internal Azure reporting. Do not delete.

Comments

@nfreear
Copy link
Contributor

nfreear commented Jan 7, 2021

Hi,

There is a missing tabindex​ attribute on video players within adaptive cards, which I can see is fixed in 'AdaptiveCards' 2020.06 (2.5.0); Pull request: microsoft/AdaptiveCards#4182.

Unfortunately, I can see that WebChat 4.11.0 still uses the older, unfixed AdaptiveCards 1.2.6.

When is WebChat likely to be updated to use the newer AdaptiveCards module please?

Note, this is an accessibility issue for keyboard and non-visual users and is a blocker for them.

Thanks,

Nick

Screenshots

Version

Describe the bug

Steps to reproduce

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior

  • The user should be able to navigate to a video embedded in a Chat-bot using the TAB key on their keyboard, and activate the triangular Start button using Enter or Space key.

Additional context

[Bug]

@nfreear nfreear added Bot Services Required for internal Azure reporting. Do not delete. Do not change color. bug Indicates an unexpected problem or an unintended behavior. customer-reported Required for internal Azure reporting. Do not delete. labels Jan 7, 2021
@gabog
Copy link

gabog commented Jan 8, 2021

Hi @compulim, can you please take a look at this one?

Thanks

@compulim
Copy link
Contributor

compulim commented Jan 11, 2021

We bumped to Adaptive Cards 2.5.0 in our dev build and it will be released in 4.12.0.

@compulim compulim added the customer-replied-to Required for internal reporting. Do not delete. label Jan 11, 2021
@nfreear
Copy link
Contributor Author

nfreear commented Jan 11, 2021

Hi @compulim,

Good to hear. Thanks for the response,

Nick

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bot Services Required for internal Azure reporting. Do not delete. Do not change color. bug Indicates an unexpected problem or an unintended behavior. customer-replied-to Required for internal reporting. Do not delete. customer-reported Required for internal Azure reporting. Do not delete.
Projects
None yet
Development

No branches or pull requests

4 participants