Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

createStore should return Store<any> than Store<unknown> #4878

Closed
compulim opened this issue Sep 26, 2023 · 0 comments · Fixed by #4877
Closed

createStore should return Store<any> than Store<unknown> #4878

compulim opened this issue Sep 26, 2023 · 0 comments · Fixed by #4877
Labels
Bot Services Required for internal Azure reporting. Do not delete. Do not change color. bug Indicates an unexpected problem or an unintended behavior. customer-reported Required for internal Azure reporting. Do not delete.

Comments

@compulim
Copy link
Contributor

Is it an issue related to Adaptive Cards?

No

Is this an accessibility issue?

No

What version of Web Chat are you using?

Development build

Which distribution are you using Web Chat from?

Unrelated

Which hosting environment does this issue primarily affect?

Others or unrelated

Which browsers and platforms do the issue happened?

Others or unrelated

Which area does this issue affect?

Others or unrelated

What is the public URL for the website?

No response

Please describe the bug

Because Web Chat did not full typed the store, returning unknown break existing signature.

We should keep returning it as any.

Do you see any errors in console log?

No response

How to reproduce the issue?

const store = createStore(...);

const { activities }: { activities: WebChatActivity[] } = store;

What do you expect?

TypeScript should not complain that store cannot be { activities: WebChatActivity[] }.

What actually happened?

TypeScript complain that store cannot be { activities: WebChatActivity[] }.

Do you have any screenshots or recordings to repro the issue?

No response

Adaptive Card JSON

No response

Additional context

No response

@compulim compulim added bug Indicates an unexpected problem or an unintended behavior. customer-reported Required for internal Azure reporting. Do not delete. Bot Services Required for internal Azure reporting. Do not delete. Do not change color. labels Sep 26, 2023
@compulim compulim mentioned this issue Sep 26, 2023
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bot Services Required for internal Azure reporting. Do not delete. Do not change color. bug Indicates an unexpected problem or an unintended behavior. customer-reported Required for internal Azure reporting. Do not delete.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant