Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade snmalloc to 0.6.2 #5496

Merged
merged 1 commit into from
Aug 2, 2023
Merged

Upgrade snmalloc to 0.6.2 #5496

merged 1 commit into from
Aug 2, 2023

Conversation

achamayou
Copy link
Member

@achamayou achamayou commented Aug 2, 2023 •
edited
Loading

One of the items under #5474

@achamayou achamayou marked this pull request as ready for review August 2, 2023 14:59
@achamayou achamayou requested a review from a team August 2, 2023 14:59
@ghost
Copy link

ghost commented Aug 2, 2023

snmalloc_upgrade_from_0.6.0_to_0.6.2@73811 aka 20230802.15 vs main ewma over 20 builds from 73522 to 73801

Click to see table

main

build_id build_number Commit latency factor ls_sgx_cft^ ls_sgx_cft_mem pi_ls_sgx_cft^ pi_ls_sgx_cft_mem ls_virtual_cft^ pi_ls_virtual_cft^ pi_basic_sgx_cft^ pi_basic_sgx_cft_mem pi_basic_virtual_cft^ ls_jwt_sgx_cft^ ls_jwt_sgx_cft_mem pi_ls_jwt_sgx_cft^ pi_ls_jwt_sgx_cft_mem ls_jwt_virtual_cft^ pi_ls_jwt_virtual_cft^ ls_js_virtual_cft^ ls_js_sgx_cft^ ls_js_sgx_cft_mem ls_full_js_virtual_cft^ ls_js_jwt_virtual_cft^ ls_full_js_sgx_cft^ ls_full_js_sgx_cft_mem hist_sgx_cft^ ls_js_jwt_sgx_cft^ ls_js_jwt_sgx_cft_mem pi_basic_mt_virtual_cft^ pi_basic_mt_sgx_cft^ pi_basic_mt_sgx_cft_mem RB put (/s)^ CHAMP put (/s)^ RB get (/s)^ CHAMP get (/s)^ pi_basic_js_virtual_cft^ pi_basic_js_sgx_cft^ pi_basic_js_sgx_cft_mem
73522 20230726.3 0.774701 20025.5 1.88908e+07 20231.4 1.25993e+07 43593.5 46399.6 22951.9 1.25993e+07 56351 6746.02 1.67936e+07 6516.4 6.30784e+06 12430 12793.8 4493.21 1739.84 1.05021e+07 3542.28 3327.47 1426.07 1.05021e+07 45817.8 1427.23 1.05021e+07 62106.4 35665.2 2.51822e+07 835763 1.18085e+06 8.15352e+06 3.07762e+07 nan nan nan
73535 20230727.1 0.789798 20098.9 1.88908e+07 20256.3 1.25993e+07 45726.3 40488.9 22886.7 1.25993e+07 56866.5 6729.54 1.67936e+07 6520.5 6.30784e+06 12443.7 12615.1 4381.25 1744.16 1.05021e+07 3547.19 3304.08 1433.26 1.05021e+07 46569.8 1427.65 1.05021e+07 74853.9 35786.2 2.30851e+07 828842 1.17948e+06 8.1552e+06 3.07863e+07 nan nan nan
73557 20230728.1 0.836629 20086.9 1.88908e+07 20271.6 1.25993e+07 45820.3 46580.1 23088.8 1.25993e+07 56332 6396.5 1.67936e+07 6521.7 6.30784e+06 12411.2 12546.4 4438.38 1742.31 1.05021e+07 3569.17 3310.11 1436.82 1.05021e+07 45127.1 1429.11 1.05021e+07 59443.4 35671.9 2.51822e+07 834242 1.18091e+06 8.15416e+06 3.12505e+07 nan nan nan
73574 20230728.9 0.812198 20009 1.88908e+07 20152.6 1.25993e+07 43649.2 46556.5 22991 1.25993e+07 55794.3 6379.23 1.67936e+07 6518.2 6.30784e+06 12398.9 12690.1 4522.53 1744.03 1.05021e+07 3537.9 3302.15 1437.8 1.05021e+07 45050.2 1431.48 1.05021e+07 63710.8 35481.2 2.30851e+07 826253 1.17636e+06 8.15345e+06 3.15261e+07 nan nan nan
73602 20230728.19 0.803596 20011.2 1.88908e+07 20232.3 1.25993e+07 45627.2 46837.7 22934.1 1.25993e+07 56194.2 6335.6 1.67936e+07 6517.7 6.30784e+06 12498.4 12678 4548.67 1738.58 1.05021e+07 3557.51 3297.85 1438.01 1.05021e+07 49016 1426.15 1.05021e+07 72391.8 35902 2.51822e+07 838863 1.18103e+06 8.15631e+06 3.08174e+07 nan nan nan
73609 20230731.1 0.774073 20054.8 1.88908e+07 20237.5 1.25993e+07 44147.5 46769.4 23012.6 1.25993e+07 55931 6731.81 1.67936e+07 6520.6 6.30784e+06 12407.8 12973.2 4381.07 1744.4 1.05021e+07 3560.03 3266.55 1434.11 1.05021e+07 46892 1429.74 1.05021e+07 59683.3 35860.5 2.51822e+07 835985 1.17981e+06 8.15342e+06 3.14661e+07 nan nan nan
73624 20230731.8 0.802067 20043.2 1.88908e+07 20285.9 1.05021e+07 43910.3 47075.2 22966.9 1.25993e+07 55368.6 6334.17 1.67936e+07 6515.9 6.30784e+06 12475.7 12634.1 4346.84 1736.08 1.05021e+07 3541.55 3284.61 1437.47 1.05021e+07 50108.1 1430.99 1.05021e+07 63159.6 35696.7 2.51822e+07 840299 1.17755e+06 8.15118e+06 3.10233e+07 nan nan nan
73634 20230731.11 0.804959 19943.9 1.88908e+07 20202 1.25993e+07 45668.8 47393.4 22972.7 1.25993e+07 55679.3 6310.97 1.67936e+07 6578.9 6.30784e+06 12506.1 12820.5 4350.24 1735.81 1.05021e+07 3543.53 3308.84 1435.9 1.05021e+07 48248.3 1423.61 1.05021e+07 69565.2 35743 2.51822e+07 829954 1.1795e+06 8.15384e+06 3.07873e+07 nan nan nan
73656 20230731.16 0.798666 20086.4 1.88908e+07 20242.9 1.25993e+07 45608.3 46948.4 22993.8 1.25993e+07 56148.2 6710.26 1.67936e+07 6535.9 6.30784e+06 12344.7 12820.5 4536.59 1743.1 1.05021e+07 3544.96 3303.55 1432.58 1.05021e+07 48199.5 1431.01 1.05021e+07 59880.2 35622.1 2.30851e+07 839873 1.17643e+06 8.04371e+06 3.10186e+07 nan nan nan
73670 20230731.18 0.821856 19987.4 1.88908e+07 20242.9 1.25993e+07 46131.2 47169.8 22951.6 1.25993e+07 55834.7 6750.12 1.67936e+07 6535.9 6.30784e+06 12466 12658.2 4422.97 1741.2 1.05021e+07 3549.87 3304.7 1433.97 1.05021e+07 40326.5 1423.32 1.05021e+07 64195.2 35730.2 2.51822e+07 831309 1.18206e+06 8.15595e+06 3.14269e+07 nan nan nan
73684 20230731.23 0.809863 19989.3 1.67936e+07 20202 1.25993e+07 45738.1 46729 22999.1 1.25993e+07 55834.7 6714.63 1.67936e+07 6493.5 6.30784e+06 12381.3 13157.9 4371.18 1741.77 1.05021e+07 3558.5 3308.84 1422.91 1.05021e+07 44588.6 1430.93 1.05021e+07 65008.9 35743 2.30851e+07 831627 1.17288e+06 8.1702e+06 3.08035e+07 nan nan nan
73692 20230731.25 0.772608 20094.3 1.88908e+07 20202 1.25993e+07 45838.4 47393.4 23015 1.25993e+07 55371 6698.4 1.67936e+07 6535.9 6.30784e+06 12467.9 12820.5 4404.81 1742.62 1.05021e+07 3474.6 3286.87 1434.63 1.05021e+07 48220.5 1430.75 1.05021e+07 71697.4 35887.3 2.51822e+07 836779 1.18395e+06 8.17229e+06 3.07905e+07 nan nan nan
73700 20230801.1 0.807228 20029.8 1.67936e+07 20242.9 1.25993e+07 45633.5 47169.8 22972.7 1.25993e+07 55741.4 6674.29 1.67936e+07 6451.6 6.30784e+06 12472.2 12658.2 4380.72 1735.54 1.05021e+07 3575.91 3284.07 1422.13 1.05021e+07 48197.2 1423.12 1.05021e+07 68811.3 35454.7 2.51822e+07 827722 1.17145e+06 8.17147e+06 3.08016e+07 nan nan nan
73711 20230801.6 0.811372 19826.9 1.88908e+07 20080.3 1.05021e+07 43668.1 45871.6 22675.7 1.25993e+07 58343.1 6678.31 1.67936e+07 6578.9 6.30784e+06 12491.8 13157.9 4341.96 1748.12 1.05021e+07 3492.46 3293.78 1427.2 1.05021e+07 47468.1 1428.99 1.05021e+07 69942.3 34873.6 2.51822e+07 830785 1.18094e+06 8.1481e+06 3.07609e+07 nan nan nan
73720 20230801.9 0.776609 19897.7 1.88908e+07 20000 1.05021e+07 43842.2 47169.8 22604 1.25993e+07 57870.4 6746.8 1.67936e+07 6666.7 6.30784e+06 11269.7 12987 4453.19 1744.24 1.05021e+07 3486.58 3256.29 1436.93 1.05021e+07 43327.3 1424.64 1.05021e+07 65423.6 34743.3 2.51822e+07 823385 1.18131e+06 8.17281e+06 3.07729e+07 nan nan nan
73734 20230801.14 0.812897 19965 1.88908e+07 20133.8 1.05021e+07 45721.1 50273.2 22758.9 1.25993e+07 55080.9 6339.77 1.67936e+07 6644.5 6.30784e+06 12362 12983.3 4541.17 1741.68 1.05021e+07 3465.49 3308.33 1436.76 1.05021e+07 42491 1425.69 1.05021e+07 62432.8 35728.9 2.51822e+07 834723 1.18456e+06 8.15449e+06 3.08476e+07 nan nan nan
73745 20230801.18 0.790283 19972.8 1.88908e+07 20042.2 1.05021e+07 45486.7 47459.5 22723.7 1.25993e+07 58615.3 6680.54 1.67936e+07 6173.8 6.30784e+06 12475.9 12740.3 4468.63 1743.88 1.05021e+07 3544.11 3290.04 1431.08 1.05021e+07 48480.8 1429.18 1.05021e+07 73698.5 35368.8 2.51822e+07 838542 1.18022e+06 8.14615e+06 3.08713e+07 4615.6 1748.8 8.40499e+06
73777 20230802.4 0.768526 19974.6 1.88908e+07 20134 1.05021e+07 45650.2 49459.7 22745.7 1.25993e+07 59718.2 6713.41 1.67936e+07 6595.7 6.30784e+06 12475.4 12926.7 4458.58 1744 1.05021e+07 3575.58 3284.09 1437.85 1.05021e+07 43652.4 1430.69 1.05021e+07 70649.9 36072.1 2.30851e+07 828420 1.17762e+06 8.13567e+06 3.10068e+07 4625.2 1748.2 8.40499e+06
73794 20230802.11 0.788545 20061.5 1.88908e+07 20114.6 1.05021e+07 45820.2 49614.7 22119 1.46964e+07 57118.1 6360.75 1.67936e+07 6653.2 6.30784e+06 12272.1 12965.6 4489.18 1740.89 1.05021e+07 3549.16 3302.1 1423.44 1.05021e+07 50154.3 1426.62 1.05021e+07 54864.6 34513.7 2.93765e+07 829086 1.18336e+06 8.17539e+06 3.08434e+07 4516.6 1714.8 1.25993e+07
73801 20230802.13 0.782836 20064.3 1.88908e+07 20060.1 1.05021e+07 45831.3 49515.5 22220.1 1.46964e+07 56374.6 6405.25 1.67936e+07 6531.2 6.30784e+06 12362 13037.1 4408.51 1758.14 1.05021e+07 3558.21 3276.33 1438.79 1.05021e+07 46647.2 1433.93 1.05021e+07 60729.3 35020 2.93765e+07 838844 1.18438e+06 8.15654e+06 3.07019e+07 4496.4 1723.6 1.25993e+07

snmalloc_upgrade_from_0.6.0_to_0.6.2

build_id build_number Commit latency factor ls_virtual_cft^ pi_ls_virtual_cft^ pi_basic_virtual_cft^ ls_sgx_cft^ ls_sgx_cft_mem pi_basic_js_virtual_cft^ pi_ls_sgx_cft^ pi_ls_sgx_cft_mem ls_jwt_virtual_cft^ pi_basic_sgx_cft^ pi_basic_sgx_cft_mem pi_ls_jwt_virtual_cft^ ls_js_virtual_cft^ pi_basic_js_sgx_cft^ pi_basic_js_sgx_cft_mem ls_full_js_virtual_cft^ ls_jwt_sgx_cft^ ls_jwt_sgx_cft_mem ls_js_jwt_virtual_cft^ pi_ls_jwt_sgx_cft^ pi_ls_jwt_sgx_cft_mem pi_basic_mt_virtual_cft^ ls_js_sgx_cft^ ls_js_sgx_cft_mem hist_sgx_cft^ ls_full_js_sgx_cft^ ls_full_js_sgx_cft_mem ls_js_jwt_sgx_cft^ ls_js_jwt_sgx_cft_mem RB put (/s)^ CHAMP put (/s)^ RB get (/s)^ CHAMP get (/s)^ pi_basic_mt_sgx_cft^ pi_basic_mt_sgx_cft_mem
73811 20230802.15 0.823237 45426.7 49726.3 56814.7 19926.6 1.88908e+07 4460.9 19987.9 1.05021e+07 12409.7 22152.3 1.46964e+07 13061.5 4443.33 1724.4 1.25993e+07 3474.12 6323.81 1.67936e+07 3303.44 6519 6.30784e+06 59264.3 1740.89 1.05021e+07 44540.2 1419.8 1.05021e+07 1424.78 1.05021e+07 840009 1.17515e+06 8.15462e+06 3.07808e+07 34682.8 2.93765e+07

images

@eddyashton eddyashton merged commit c2e46c2 into microsoft:main Aug 2, 2023
@achamayou achamayou added auto-backport Automatically backport this PR to LTS branch 4.x-todo PRs which should be backported to 4.x labels Sep 4, 2023
@jumaffre jumaffre added auto-backport Automatically backport this PR to LTS branch and removed auto-backport Automatically backport this PR to LTS branch labels Sep 11, 2023
@ghost ghost mentioned this pull request Sep 11, 2023
Merged
@ghost ghost added the backported This PR was successfully backported to LTS branch label Sep 11, 2023
ghost pushed a commit that referenced this pull request Sep 11, 2023
@achamayou
Upgrade snmalloc to 0.6.2 (#5496)
d830488 
(cherry picked from commit c2e46c2)
achamayou pushed a commit that referenced this pull request Sep 11, 2023
[release/4.x] Cherry pick: Upgrade snmalloc to 0.6.2 (#5496) (#5644)
f40bc6b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eddyashton eddyashton eddyashton approved these changes

Assignees
No one assigned
Labels
4.x-todo PRs which should be backported to 4.x auto-backport Automatically backport this PR to LTS branch backported This PR was successfully backported to LTS branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@achamayou @eddyashton @jumaffre