Linux_OSX_Shared/Sample.cpp Build Error

[bpavesi]

When i build the sample i get this Error:

g++ sample.cpp -lstdc++ -std=c++0x -I../lib/Jsrt -Wl,--whole-archive ../out/Debug/libChakraCore.so -Wl,--no-whole-archive -pthread -lm -ldl -licuuc -Wno-c++11-compat-deprecated-writable-strings -Wno-deprecated-declarations -Wno-unknown-warning-option -o sample.o
sample.cpp: In function ‘int main()’:
sample.cpp:61:70: error: too few arguments to function ‘JsErrorCode JsCopyString(JsValueRef, char*, size_t, size_t*, size_t*)’
FAIL_CHECK(JsCopyString(resultJSString, nullptr, 0, &stringLength));
^
sample.cpp:15:31: note: in definition of macro ‘FAIL_CHECK’
JsErrorCode errCode = cmd;
^
In file included from sample.cpp:6:0:
../lib/Jsrt/ChakraCore.h:310:5: note: declared here
JsCopyString(
^
sample.cpp:63:81: error: too few arguments to function ‘JsErrorCode JsCopyString(JsValueRef, char*, size_t, size_t*, size_t*)’
FAIL_CHECK(JsCopyString(resultJSString, resultSTR, stringLength + 1, nullptr));
^
sample.cpp:15:31: note: in definition of macro ‘FAIL_CHECK’
JsErrorCode errCode = cmd;
^
In file included from sample.cpp:6:0:
../lib/Jsrt/ChakraCore.h:310:5: note: declared here
JsCopyString(
^
At global scope:
cc1plus: warning: unrecognized command line option ‘-Wno-unknown-warning-option’
cc1plus: warning: unrecognized command line option ‘-Wno-c++11-compat-deprecated-writable-strings’
Makefile:32: set di istruzioni per l'obiettivo "testmake" non riuscito
make: *** [testmake] Errore 1

[liminzhu]

Hey @bpavesi , thanks for the issue! We recently changed the signature of JsCopyString chakra-core/ChakraCore#3433, therefore this sample needs an update. I will get that out shortly.

[liminzhu]

It should be working now with 57c761f.

[bpavesi]

it works!
tnx

[liminzhu]

Close since it is resolved then.