Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can we remove the use of If DEBUG where possible? #335

Open
panayot-cankov opened this issue Nov 3, 2021 · 0 comments
Open

Can we remove the use of If DEBUG where possible? #335

panayot-cankov opened this issue Nov 3, 2021 · 0 comments

Comments

@panayot-cankov
Copy link
Contributor

panayot-cankov commented Nov 3, 2021

Any chance we could remove these:

#if DEBUG
Path = path;
#else
Path = @"..";
#endif

There are just a few places where the CTS switches behavior based on configuration. I think it would be much more clean if this path here was passed as ".." from where CTS is used in WebTemplateStudio and WindowsTemplateStudio. Or maybe if it were a command line default "..", and the path was used for development of the CLI.

Do you accept PRs?

There is similar behavior a few more places, where I think a command line option could switch the behavior closing the gap between Debug and Release configurations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant