Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPIR-V] No vk::RawBufferStore to go along with vk::RawBufferLoad #4568

Closed
natevm opened this issue Aug 2, 2022 · 2 comments · Fixed by #4573
Closed

[SPIR-V] No vk::RawBufferStore to go along with vk::RawBufferLoad #4568

natevm opened this issue Aug 2, 2022 · 2 comments · Fixed by #4573
Labels
spirv Work related to SPIR-V

Comments

@natevm
Copy link
Contributor

natevm commented Aug 2, 2022

Hello,

I am using the vk::RayBufferLoad functionality described here: https://github.com/microsoft/DirectXShaderCompiler/blob/main/docs/SPIR-V.rst#rawbufferload

...and it works quite well for reading data from a device address. But now I need to store a result back into that buffer...

Is there anything standing in the way of adding a vk::RawBufferStore too?

@natevm
Copy link
Contributor Author

natevm commented Aug 2, 2022

I suspect this pull request which added vk::RawBufferLoad could be used to track what would be required to also support a store.

#4069

@cassiebeckley cassiebeckley added the spirv Work related to SPIR-V label Aug 8, 2022
@natevm
Copy link
Contributor Author

natevm commented Aug 10, 2022

Okay, I have this feature successfully implemented in pull request #4573 . I also added some documentation and a unit test which are passing. The PR was approved, so just needs to have someone with write access to merge it in.

Once that's done, we can close this issue. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
spirv Work related to SPIR-V
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants