From 76fb0b62a5bec3f6c5b7f9730e89bb1f031c12ff Mon Sep 17 00:00:00 2001 From: James Lamb Date: Sun, 5 Dec 2021 06:48:23 -0600 Subject: [PATCH] [R-package] remove support for '...' in Booster reset_parameter() (#4856) --- R-package/R/lgb.Booster.R | 13 +------------ 1 file changed, 1 insertion(+), 12 deletions(-) diff --git a/R-package/R/lgb.Booster.R b/R-package/R/lgb.Booster.R index c7c50864d7e0..749f175491f4 100644 --- a/R-package/R/lgb.Booster.R +++ b/R-package/R/lgb.Booster.R @@ -177,23 +177,12 @@ Booster <- R6::R6Class( }, - reset_parameter = function(params, ...) { - - additional_params <- list(...) - if (length(additional_params) > 0L) { - warning(paste0( - "Booster$reset_parameter(): Found the following passed through '...': " - , paste(names(additional_params), collapse = ", ") - , ". These will be used, but in future releases of lightgbm, this warning will become an error. " - , "Add these to 'params' instead." - )) - } + reset_parameter = function(params) { if (methods::is(self$params, "list")) { params <- utils::modifyList(self$params, params) } - params <- utils::modifyList(params, additional_params) params_str <- lgb.params2str(params = params) self$restore_handle()