From bdee57c0aa4a0c45e1d60f3d319a2c3a09527db0 Mon Sep 17 00:00:00 2001 From: Nikita Titov Date: Sat, 28 Aug 2021 08:31:49 +0300 Subject: [PATCH 1/4] [docs] update links to SynapseML (former MMLSpark) (#4564) * Update README.md * Update Parallel-Learning-Guide.rst --- README.md | 2 +- docs/Parallel-Learning-Guide.rst | 12 ++++++------ 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/README.md b/README.md index 079a178707c0..ed6346162469 100644 --- a/README.md +++ b/README.md @@ -91,7 +91,7 @@ Shapash (model visualization and interpretation): https://github.com/MAIF/shapas dtreeviz (decision tree visualization and model interpretation): https://github.com/parrt/dtreeviz -MMLSpark (LightGBM on Spark): https://github.com/Azure/mmlspark +SynapseML (LightGBM on Spark): https://github.com/microsoft/SynapseML Kubeflow Fairing (LightGBM on Kubernetes): https://github.com/kubeflow/fairing diff --git a/docs/Parallel-Learning-Guide.rst b/docs/Parallel-Learning-Guide.rst index b3609554ee36..45a89312b1c0 100644 --- a/docs/Parallel-Learning-Guide.rst +++ b/docs/Parallel-Learning-Guide.rst @@ -47,13 +47,13 @@ This section describes how to run distributed LightGBM training in various progr Apache Spark ^^^^^^^^^^^^ -Apache Spark users can use `MMLSpark`_ for machine learning workflows with LightGBM. This project is not maintained by LightGBM's maintainers. +Apache Spark users can use `SynapseML`_ for machine learning workflows with LightGBM. This project is not maintained by LightGBM's maintainers. -See `this MMLSpark example`_ and `the MMLSpark documentation`_ for additional information on using LightGBM on Spark. +See `this SynapseML example`_ and `the SynapseML documentation`_ for additional information on using LightGBM on Spark. .. note:: - ``MMLSpark`` is not maintained by LightGBM's maintainers. Bug reports or feature requests should be directed to https://github.com/Azure/mmlspark/issues. + ``SynapseML`` is not maintained by LightGBM's maintainers. Bug reports or feature requests should be directed to https://github.com/microsoft/SynapseML/issues. Dask ^^^^ @@ -453,9 +453,9 @@ Example .. _Dask: https://docs.dask.org/en/latest/ -.. _MMLSpark: https://aka.ms/spark +.. _SynapseML: https://aka.ms/spark -.. _this MMLSpark example: https://github.com/Azure/mmlspark/blob/master/notebooks/LightGBM%20-%20Overview.ipynb +.. _this SynapseML example: https://github.com/microsoft/SynapseML/blob/master/notebooks/LightGBM%20-%20Overview.ipynb .. _the Dask Array documentation: https://docs.dask.org/en/latest/array.html @@ -467,7 +467,7 @@ Example .. _the metrics functions from dask-ml: https://ml.dask.org/modules/api.html#dask-ml-metrics-metrics -.. _the MMLSpark Documentation: https://github.com/Azure/mmlspark/blob/master/docs/lightgbm.md +.. _the SynapseML Documentation: https://github.com/microsoft/SynapseML/blob/master/docs/lightgbm.md .. _these Dask examples: https://github.com/microsoft/lightgbm/tree/master/examples/python-guide/dask From ba8533c1eea49303e238defb9b47080d251e8f01 Mon Sep 17 00:00:00 2001 From: Nikita Titov Date: Sat, 28 Aug 2021 20:58:03 +0300 Subject: [PATCH 2/4] =?UTF-8?q?[docs]=20add=20Jos=C3=A9=20Morales=20to=20r?= =?UTF-8?q?epo=20maintainers=20(#4563)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit * Update CODEOWNERS * Update FAQ.rst --- .github/CODEOWNERS | 4 ++-- docs/FAQ.rst | 1 + 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index 58398673c215..de0865111f7c 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -33,8 +33,8 @@ R-package/ @Laurae2 @jameslamb python-package/ @StrikerRUS @chivee @wxchan @henry0312 @shiyu1994 @jameslamb # Dask integration -python-package/lightgbm/dask.py @jameslamb -tests/python_package_test/test_dask.py @jameslamb +python-package/lightgbm/dask.py @jameslamb @jmoralez +tests/python_package_test/test_dask.py @jameslamb @jmoralez # helpers helpers/ @StrikerRUS @guolinke diff --git a/docs/FAQ.rst b/docs/FAQ.rst index 9b3cd7e45797..5b89f90ac71a 100644 --- a/docs/FAQ.rst +++ b/docs/FAQ.rst @@ -26,6 +26,7 @@ You may also ping a member of the core team according to the relevant area of ex - `@btrotta `__ **Belinda Trotta** (C++ code) - `@Laurae2 `__ **Damien Soukhavong** (R-package) - `@jameslamb `__ **James Lamb** (R-package / Dask-package) +- `@jmoralez `__ **José Morales** (Dask-package) - `@wxchan `__ **Wenxuan Chen** (Python-package) - `@henry0312 `__ **Tsukasa Omoto** (Python-package) - `@StrikerRUS `__ **Nikita Titov** (Python-package) From b765fa6efb9372e93292861290dd81428cc7d63a Mon Sep 17 00:00:00 2001 From: James Lamb Date: Sat, 28 Aug 2021 20:20:05 +0100 Subject: [PATCH 3/4] [R-package] use {testthat} SummaryReporter in tests (#4567) --- R-package/tests/testthat.R | 1 + 1 file changed, 1 insertion(+) diff --git a/R-package/tests/testthat.R b/R-package/tests/testthat.R index 4a1d1268db36..4752952740b2 100644 --- a/R-package/tests/testthat.R +++ b/R-package/tests/testthat.R @@ -5,4 +5,5 @@ test_check( package = "lightgbm" , stop_on_failure = TRUE , stop_on_warning = FALSE + , reporter = testthat::SummaryReporter$new() ) From ee5636f16be636e11dbe3e2960996f52cb846aec Mon Sep 17 00:00:00 2001 From: Nikita Titov Date: Sat, 28 Aug 2021 22:26:31 +0300 Subject: [PATCH 4/4] [python][docs] Refer to string type as `str` in docstrings (#4565) --- python-package/lightgbm/dask.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/python-package/lightgbm/dask.py b/python-package/lightgbm/dask.py index e6ee708681df..f7429ab3d67c 100644 --- a/python-package/lightgbm/dask.py +++ b/python-package/lightgbm/dask.py @@ -443,8 +443,8 @@ def _train( Initial model score for each validation set in eval_set. eval_group : list of Dask Arrays, Dask Series or None, optional (default=None) Group/query for each validation set in eval_set. - eval_metric : string, callable, list or None, optional (default=None) - If string, it should be a built-in evaluation metric to use. + eval_metric : str, callable, list or None, optional (default=None) + If str, it should be a built-in evaluation metric to use. If callable, it should be a custom evaluation metric, see note below for more details. If list, it can be a list of built-in metrics, a list of custom evaluation metrics, or a mix of both. In either case, the ``metric`` from the Dask model parameters (or inferred from the objective) will be evaluated and used as well.