Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debug flag in cmake #1588

Closed
alokpr opened this issue Aug 14, 2018 · 3 comments
Closed

Debug flag in cmake #1588

alokpr opened this issue Aug 14, 2018 · 3 comments

Comments

@alokpr
Copy link

alokpr commented Aug 14, 2018

Environment info

Operating System: x86_64-linux-gnu

CPU: Intel(R) Core(TM) i7-7700 CPU @ 3.60GHz

C++/Python/R version: gcc version 5.4.0 20160609 (Ubuntu 5.4.0-6ubuntu1~16.04.9)

Error message

https://github.com/Microsoft/LightGBM/blob/master/CMakeLists.txt#L111

CMakeLists.txt specifies -O3 optimization flag, which makes it difficult to build the library for different build configs. Optimization flag should be defined as part of external build config using CMAKE_BUILD_TYPE=[Debug,Release].

@guolinke
Copy link
Collaborator

For most users, Debug flags are not needed.
For developers, I think they can aware these flags and able to change them correctly.

However, having a Debug parameter for cmake is great. PR is welcomed.

@guolinke guolinke changed the title CMakeLists.txt specifies optimization flag Debug flag in cmake Aug 1, 2019
@guolinke guolinke closed this as completed Aug 1, 2019
@StrikerRUS
Copy link
Collaborator

Closed in favor of being in #2302. We decided to keep all feature requests in one place.

Welcome to contribute this feature! Please re-open this issue (or post a comment if you are not a topic starter) if you are actively working on implementing this feature.

@guolinke guolinke mentioned this issue Feb 26, 2020
1 task
@guolinke guolinke reopened this Feb 26, 2020
@StrikerRUS
Copy link
Collaborator

Added in #2825.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants