-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ci] [R-package] stack-use-after-scope issues detected by address sanitizer #4674
Comments
You'll probably need to use the same compiler versions as CRAN. |
Yep for sure! I've listed the complete configuration CRAN uses (which includes compiler versions) in the issue description. |
Good NewsI was able to reproduce the problems cited by CRAN's gcc-ASAN checks tonight!!! Why LightGBM's existing CI jobs didn't catch the same errors as
|
This issue has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this. |
Description
On the 3.3.0 release of
{lightgbm}
(#4633), CRAN's "additional checks" with address sanitizers (ASAN) detected some issues. Originally noted at #4633 (comment).clang (link)
full logs (click me)
gcc (link)
full logs (click me)
Thanks to @david-cortes for noting the likely root cause of these errors, in #4633 (comment).
Additional Comments
The last time CRAN detected memory issues in its "Additional Checks", they told us we had a few weeks to fix it and that if we didn't,
{lightgbm}
would be removed from CRAN: #3338 (comment)At the time, I believed that we had successfully replicated CRAN's testing setup in LightGBM's continuous integration: #3439 (comment).
Today, LightGBM runs 3 CI jobs on every commits using UBSAN/ASAN.
gcc
, Linux):LightGBM/.github/workflows/r_package.yml
Lines 175 to 176 in 5c8a331
clang, Linux
):LightGBM/.vsts-ci.yml
Lines 120 to 122 in 5c8a331
clang
, Linux):LightGBM/.vsts-ci.yml
Lines 233 to 236 in 5c8a331
None of these jobs produce the issues in CRAN's additional checks.
As of this writing, based on the information at https://www.stats.ox.ac.uk/pub/bdr/memtests/README.txt (found from https://cran.r-project.org/web/checks/check_issue_kinds.html) here is the configuration CRAN is using for those tests.
CRAN memtest configs (click me)
The text was updated successfully, but these errors were encountered: