Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C public API: Rename FastConfig to SingleRowPredictor #6286

Open
Ten0 opened this issue Jan 24, 2024 · 2 comments
Open

C public API: Rename FastConfig to SingleRowPredictor #6286

Ten0 opened this issue Jan 24, 2024 · 2 comments

Comments

@Ten0
Copy link
Contributor

Ten0 commented Jan 24, 2024

Fast Config in the C API is poorly named, in that it's actually specific to single row prediction, and doesn't only contain config.
-> the items named around FastConfig should be renamed to be made named around SingleRowPredictor, because that is what they are actually relating to.
We should make this change in the next release which may contain breaking changes.

https://github.com/Ten0/LightGBM/blob/063008a7e5caafa1c5a0171bf5cad10bda3e044c/src/c_api.cpp#L2122-L2132
(link to be made pointing to master once #6024 is merged)

@jameslamb
Copy link
Collaborator

FastConfig is poorly named

Can you suggest some names that you think are more informative or clearer?

@Ten0
Copy link
Contributor Author

Ten0 commented Jan 26, 2024

Can you suggest some names that you think are more informative or clearer?

Whoops, looks like I forgot this this time. 😅
Thanks, updated message above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants