-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[python] refine pandas support #960
Comments
I think, we can explicitly invoke pandas features (e.g. column names, categorical columns, etc.) at sklearn wrapper level and then pass data as numpy array. In this case all sklearn checks will be performed for pandas too. |
@StrikerRUS I am not sure I get it. The pandas support should be independent to sklearn support. You can take a try if you have a good idea. |
@wxchan I'm not sure it's "good idea"... So, I offer to extract all pandas features (column names, categorical columns, etc.) before sklearn checks and it will allow to perform these checks without loosing pandas features. What do you think? |
@StrikerRUS I edit some tasks I can think of. You can add more you think it's necessary. |
@wxchan Yeah, great idea about small separate functions! |
I haven't taken a detailed look at this yet, but it could be useful. |
Why still receiving a warning from lightgbm ver 2.2.2 with python 3.6.6 in ubuntu. lightgbm/basic.py:752: UserWarning: categorical_feature in param dict is overridden. warnings.warn('categorical_feature in param dict is overridden.') Whether category dtypes were set in pandas dataframe or as a list of categorical_feature in lightgbm Dataset or training. Why for the warning after the fix of 792? |
Closed in favor of being in #2302. We decided to keep all feature requests in one place. Welcome to contribute this feature! Please re-open this issue (or post a comment if you are not a topic starter) if you are actively working on implementing this feature. |
to do list:
_data_from_pandas:
_label_from_pandas: support category?
pandas_categorical
section into model files (more readable) (Refactoring the presentation ofpandas_categorical
section in model files #1201)The text was updated successfully, but these errors were encountered: