Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[python][ci] start to support Python 3.8 #2713

Merged
merged 8 commits into from
Apr 13, 2020
Merged

[python][ci] start to support Python 3.8 #2713

merged 8 commits into from
Apr 13, 2020

Conversation

StrikerRUS
Copy link
Collaborator

Currently is blocked by the following upstream conda packaging issue: ContinuumIO/anaconda-issues#11514.

Not changing default PYTHON_VERSION at CI services as 3.8 is still having a lot of problems in terms of third-party packages availability.

@StrikerRUS
Copy link
Collaborator Author

ContinuumIO/anaconda-issues#11514 was fixed yesterday.
But now I realized that this PR is actually blocked by one more issue: #2628. That issue was the reason we're supporting only "scikit-learn<=0.21.3" for now and support for Python 3.8 in scikit-learn was introduced only in 0.22 version. So, we should wait for scikit-learn/scikit-learn#16241.

Copy link
Collaborator

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@jameslamb
Copy link
Collaborator

Looks good to me!

^ to be clear, I'm ok with the changes whenever the build works. Just mean I have no other things to add beyond that.

@StrikerRUS
Copy link
Collaborator Author

@henry0312 I remember you were against setting new Python as default version before x.1 release. Now that Python 3.8.2 is released, I'm bumping default versions at CI side.

@StrikerRUS StrikerRUS merged commit 6c19539 into master Apr 13, 2020
@StrikerRUS StrikerRUS deleted the py38 branch April 13, 2020 22:08
@lock lock bot locked as resolved and limited conversation to collaborators Jun 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants