[R-package] allow R to pick between -fPIC and -fpic for CRAN package #3261
+0
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think we can remove setting
CPICFLAGS
inMakevars.in
andMakevars.win.in
in the R package. I noticed in the logs from R Hub (#629 (comment)) that my choioce was being ignored anyway...-fpic
is used in many of the jobs.Re-reading "Writing R Extensions", I see that I probably should have been using
CXX11PICFLAGS
.In this PR, I propose just removing
CPICFLAGS
from these Makefiles and using whatever values R chooses based on the environment it is installed in. That should slightly simplify our configuration and reduce the risk of the CRAN package failing checks on the many obscure environments CRAN uses for testing.