[tests][dask] test all boosting types (fixes #3896) #4119
Conversation
There was a problem hiding this comment.
This looks great, thanks so much for the contribution amd for documenting the issues you faced with random forest mode in #4118. @StrikerRUS are you ok with this increase in the number of tests? I think these are providing valuable new coverage and are worth it, but want to get your opinion.
There was a problem hiding this comment.
@StrikerRUS are you ok with this increase in the number of tests? I think these are providing valuable new coverage and are worth it, but want to get your opinion.
Thank you. I support this and think this is valuable.
Just one question below.
| assert_eq(s1, s2, atol=0.01) | ||
| assert_eq(p1_proba, p2_proba, atol=0.8) | ||
| else: | ||
| assert_eq(p1, p2) |
There was a problem hiding this comment.
Why are we dropping assert_eq(s1, s2) from the else branch?
There was a problem hiding this comment.
That was totally my bad, I lost it when splitting the statements. I've included it in
5d7001d
There was a problem hiding this comment.
thanks for catching it @StrikerRUS ! I missed it too
|
This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this. |
This includes all boosting types (gbdt, rf, goss, dart) in
test_classifier,test_regressorandtest_ranker