Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] remove output parametrization from two Dask tests #4123

Merged
merged 2 commits into from
Mar 27, 2021
Merged

Conversation

StrikerRUS
Copy link
Collaborator

Save CI time.

I think these tests are for specific network params and we don't test something principally new by feeding different data types.

Copy link
Collaborator

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oooo yes I agree! Nice reduction in the tests without losing coverage, thank you

@StrikerRUS StrikerRUS merged commit d32ee23 into master Mar 27, 2021
@StrikerRUS StrikerRUS deleted the dask_tests branch March 27, 2021 21:10
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants