Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[python] added f-strings to python-package/setup.py #4145

Merged
merged 2 commits into from
Mar 31, 2021
Merged

[python] added f-strings to python-package/setup.py #4145

merged 2 commits into from
Mar 31, 2021

Conversation

NovusEdge
Copy link
Contributor

No description provided.

@NovusEdge
Copy link
Contributor Author

#4136

@StrikerRUS StrikerRUS mentioned this pull request Mar 30, 2021
Closed
37 tasks
StrikerRUS
StrikerRUS requested changes Mar 30, 2021
View reviewed changes
Copy link
Collaborator

@StrikerRUS StrikerRUS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One mistake below, everything else looks fine!

python-package/setup.py Outdated Show resolved Hide resolved
@NovusEdge NovusEdge closed this Mar 31, 2021
@NovusEdge NovusEdge reopened this Mar 31, 2021
@NovusEdge
Copy link
Contributor Author

One mistake below, everything else looks fine!

Could you please mention the line where the mistake is.

@jameslamb
Copy link
Collaborator

One mistake below, everything else looks fine!

Could you please mention the line where the mistake is.

it is right here: #4145 (comment)

@NovusEdge @StrikerRUS
Update python-package/setup.py
ac3ab1e 
Co-authored-by: Nikita Titov <nekit94-08@mail.ru>
@NovusEdge NovusEdge requested a review from StrikerRUS March 31, 2021 04:06
@StrikerRUS
Copy link
Collaborator

@NovusEdge

Could you please mention the line where the mistake is.

GitHub review comments are posted with a small visible piece of code. Most often, the last line of that codepiece is the line review comment is referring to.

image

Also, GitHub has recently introduced "Review suggestions". So that reviewers now can suggest code changes directly in the review comments:

image

Contributors, in case they are agree with a suggestion, are able to commit the suggested change directly in the browser by clicking "Commit suggestion" button or commit multiple suggestion at one time ("Add suggestion to batch" button).

StrikerRUS
StrikerRUS approved these changes Mar 31, 2021
View reviewed changes
Copy link
Collaborator

@StrikerRUS StrikerRUS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@NovusEdge Thanks for your contribution!

@StrikerRUS StrikerRUS changed the title added f-strings to python-package/setup.py [python] added f-strings to python-package/setup.py Mar 31, 2021
@StrikerRUS StrikerRUS merged commit 593aef3 into microsoft:master Mar 31, 2021
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@StrikerRUS StrikerRUS StrikerRUS approved these changes

@chivee chivee Awaiting requested review from chivee

@henry0312 henry0312 Awaiting requested review from henry0312

@jameslamb jameslamb Awaiting requested review from jameslamb jameslamb is a code owner

@shiyu1994 shiyu1994 Awaiting requested review from shiyu1994 shiyu1994 is a code owner

@wxchan wxchan Awaiting requested review from wxchan

Assignees
No one assigned
Labels
maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NovusEdge @jameslamb @StrikerRUS