-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[python] added f-strings to docs/conf.py #4147
Conversation
@StrikerRUS |
Please see my suggestions at #4142 (review). These apply to all of the PRs you've opened, and I think will help you debug locally. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@NovusEdge Thanks! Please take a look at my comments below:
Co-authored-by: Nikita Titov <nekit94-08@mail.ru>
Co-authored-by: Nikita Titov <nekit94-08@mail.ru>
Co-authored-by: Nikita Titov <nekit94-08@mail.ru>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
I don't believe that macOS R-package jobs are failing due to the changes from this PR. I guess we can wait a little bit with a hope that issues will go away without our help.
Hopefully should be resolved soon! Looks like our old friend, the
https://github.com/microsoft/LightGBM/pull/4147/checks?check_run_id=2254678263 |
I've updated this PR to latest Thanks for the help with these @NovusEdge ! |
This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this. |
No description provided.