[R-package] allow construction of Dataset from CSV without header (fixes #4553) #4554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StrikerRUS
approved these changes
Aug 25, 2021
There was a problem hiding this comment.
Explicitly header argument is used in prediction
https://lightgbm.readthedocs.io/en/latest/C-API.html#c.LGBM_BoosterPredictForFile
not in Dataset creation
https://lightgbm.readthedocs.io/en/latest/C-API.html#c.LGBM_DatasetCreateFromFile
For Dataset creation it is enought to have header parameter among additional params.
https://lightgbm.readthedocs.io/en/latest/Parameters.html#header
|
This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4553.
Turns out that that bug was caused by some code that is unnecessary, and can be safely removed.
This PR also adds tests covering the creation of Datasets from CSV files with and without headers.