-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
python: use nose for tests #483
Conversation
f76842f
to
fda243a
Compare
@wxchan can you review this ? |
I rebased the current master to fix conflict. |
do we need nose and rednose in requirement.txt? |
@wxchan no, however it is useful (https://github.com/Microsoft/LightGBM/pull/483/files#diff-354f30a63fb0907d4ad57269548329e3R36) |
just FYI: nose is almost unmaintained now, last release was in 2015, last commit was a year ago, developers created nose2 which haven't got traction. I believe most nose users are switching to pytest these days, which is much better supported. |
I'll check nose2 and pytest. |
I think nose is enough for LightGBM, because
|
Yeah, nose is a proven workhorse, and likely it'll work fine. My point is that pytest has all the same benefits (it is mentioned in python docs, provides similar features and similar ease of use - it can even run nose tests), and its last release was in 2017, not in 2015, so it can be a more future-proof choice. |
http://nose.readthedocs.io/en/latest/index.html
This is the first commit of #261.
(I'm very sorry for too late starting)