From d53fdbc5f7b98cf14d27861da7ee19945267cdbb Mon Sep 17 00:00:00 2001
From: Brian Kroth <bpkroth@microsoft.com>
Date: Mon, 19 Aug 2024 19:51:55 +0000
Subject: [PATCH] Convert - to _ in parse_extras

---
 mlos_bench/mlos_bench/launcher.py                       | 4 ++++
 mlos_bench/mlos_bench/tests/launcher_in_process_test.py | 2 +-
 2 files changed, 5 insertions(+), 1 deletion(-)

diff --git a/mlos_bench/mlos_bench/launcher.py b/mlos_bench/mlos_bench/launcher.py
index 9024b15adf..339a11963d 100644
--- a/mlos_bench/mlos_bench/launcher.py
+++ b/mlos_bench/mlos_bench/launcher.py
@@ -399,6 +399,10 @@ def _try_parse_extra_args(cmdline: Iterable[str]) -> Dict[str, TunableValue]:
             # Handles missing trailing elem from last --key arg.
             raise ValueError("Command line argument has no value: " + key)
 
+        # Convert "max-suggestions" to "max_suggestions" for compatibility with
+        # other CLI options to use as common python/json variable replacements.
+        config = {k.replace("-", "_"): v for k, v in config.items()}
+
         _LOG.debug("Parsed config: %s", config)
         return config
 
diff --git a/mlos_bench/mlos_bench/tests/launcher_in_process_test.py b/mlos_bench/mlos_bench/tests/launcher_in_process_test.py
index 6fe340c9eb..eb20b1abab 100644
--- a/mlos_bench/mlos_bench/tests/launcher_in_process_test.py
+++ b/mlos_bench/mlos_bench/tests/launcher_in_process_test.py
@@ -31,7 +31,7 @@
                 "mlos_bench/mlos_bench/tests/config/cli/mock-opt.jsonc",
                 "--trial_config_repeat_count",
                 "3",
-                "--max_suggestions",
+                "--max-suggestions",
                 "3",
                 "--mock_env_seed",
                 "42",  # Noisy Mock Environment.