From d82634688f04e95c2fd4c961c3e2802d1f9d68e5 Mon Sep 17 00:00:00 2001 From: Brian Kroth Date: Fri, 4 Oct 2024 16:13:33 +0000 Subject: [PATCH] Allow empty tunable values to represent the defaults --- .../config/schemas/tunables/tunable-values-schema.json | 1 - .../good/full/bare-tunable-values-with-schema.jsonc | 2 ++ .../good/full/empty-tunable-values-with-schema.jsonc | 4 ++++ .../good/partial/empty-tunable-values-without-schema.jsonc | 3 +++ 4 files changed, 9 insertions(+), 1 deletion(-) create mode 100644 mlos_bench/mlos_bench/tests/config/schemas/tunable-values/test-cases/good/full/empty-tunable-values-with-schema.jsonc create mode 100644 mlos_bench/mlos_bench/tests/config/schemas/tunable-values/test-cases/good/partial/empty-tunable-values-without-schema.jsonc diff --git a/mlos_bench/mlos_bench/config/schemas/tunables/tunable-values-schema.json b/mlos_bench/mlos_bench/config/schemas/tunables/tunable-values-schema.json index 186007a449..e14130dbca 100644 --- a/mlos_bench/mlos_bench/config/schemas/tunables/tunable-values-schema.json +++ b/mlos_bench/mlos_bench/config/schemas/tunables/tunable-values-schema.json @@ -12,7 +12,6 @@ "type": ["string", "number", "boolean"] } }, - "minProperties": 1, "not": { "required": ["tunable_values"] } diff --git a/mlos_bench/mlos_bench/tests/config/schemas/tunable-values/test-cases/good/full/bare-tunable-values-with-schema.jsonc b/mlos_bench/mlos_bench/tests/config/schemas/tunable-values/test-cases/good/full/bare-tunable-values-with-schema.jsonc index a91c629b61..2e5379d0df 100644 --- a/mlos_bench/mlos_bench/tests/config/schemas/tunable-values/test-cases/good/full/bare-tunable-values-with-schema.jsonc +++ b/mlos_bench/mlos_bench/tests/config/schemas/tunable-values/test-cases/good/full/bare-tunable-values-with-schema.jsonc @@ -1,4 +1,6 @@ { + "$schema": "https://raw.githubusercontent.com/microsoft/MLOS/main/mlos_bench/mlos_bench/config/schemas/tunables/tunable-values-schema.json", + "foo": "bar", "int": 1, "float": 1.1, diff --git a/mlos_bench/mlos_bench/tests/config/schemas/tunable-values/test-cases/good/full/empty-tunable-values-with-schema.jsonc b/mlos_bench/mlos_bench/tests/config/schemas/tunable-values/test-cases/good/full/empty-tunable-values-with-schema.jsonc new file mode 100644 index 0000000000..fc43969b4d --- /dev/null +++ b/mlos_bench/mlos_bench/tests/config/schemas/tunable-values/test-cases/good/full/empty-tunable-values-with-schema.jsonc @@ -0,0 +1,4 @@ +{ + "$schema": "https://raw.githubusercontent.com/microsoft/MLOS/main/mlos_bench/mlos_bench/config/schemas/tunables/tunable-values-schema.json" + // empty tunable values represents the defaults +} diff --git a/mlos_bench/mlos_bench/tests/config/schemas/tunable-values/test-cases/good/partial/empty-tunable-values-without-schema.jsonc b/mlos_bench/mlos_bench/tests/config/schemas/tunable-values/test-cases/good/partial/empty-tunable-values-without-schema.jsonc new file mode 100644 index 0000000000..c6bd77b952 --- /dev/null +++ b/mlos_bench/mlos_bench/tests/config/schemas/tunable-values/test-cases/good/partial/empty-tunable-values-without-schema.jsonc @@ -0,0 +1,3 @@ +{ + // empty tunable values represents the defaults +}