Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to ignore targets when determining if a build request matches a cache entry #100

Merged
merged 1 commit into from
Oct 31, 2024

Conversation

dfederm
Copy link
Member

@dfederm dfederm commented Oct 30, 2024

Add ability to ignore targets when determining if a build request matches a cache entry

Copy link
Member

@lifengl lifengl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it looks good to me. Thanks a lot to take care of it.

@dfederm dfederm closed this Oct 30, 2024
@dfederm dfederm reopened this Oct 30, 2024
@dfederm dfederm enabled auto-merge (squash) October 30, 2024 23:51
@dfederm
Copy link
Member Author

dfederm commented Oct 30, 2024

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@dfederm dfederm closed this Oct 31, 2024
auto-merge was automatically disabled October 31, 2024 00:02

Pull request was closed

@dfederm dfederm reopened this Oct 31, 2024
@dfederm
Copy link
Member Author

dfederm commented Oct 31, 2024

Pipeline stuck with the following error:

fatal: couldn't find remote ref refs/pull/100/merge

Probably caused by closing and re-opening the PR to re-trigger the license/cla check which was stuck.

Originally passing pipeline here: https://dev.azure.com/msbuildcache/public/_build/results?buildId=635&view=results

Based on all that, just forcing in the change.

@dfederm dfederm merged commit 89d947d into main Oct 31, 2024
4 of 6 checks passed
@dfederm dfederm deleted the ignore-targets branch October 31, 2024 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants