Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change MSBUILDCACHE_CONNECTIONSTRING -> MSBCACHE_CONNECTIONSTRING #97

Merged
merged 1 commit into from
Oct 25, 2024

Conversation

dfederm
Copy link
Member

@dfederm dfederm commented Oct 25, 2024

Env vars prefixed by "MSBuild" automatically get logged, and since this one contains a secret, that's a bad thing.

This renames the environment variable to avoid this.

Note that this is a breaking change!

@dfederm dfederm enabled auto-merge (squash) October 25, 2024 22:27
@dfederm dfederm disabled auto-merge October 25, 2024 23:35
@dfederm dfederm merged commit adfe128 into main Oct 25, 2024
6 checks passed
@dfederm dfederm deleted the env-var branch October 25, 2024 23:35
@KalleOlaviNiemitalo
Copy link

Makes me wonder if MSBuild could be given a feature similar to MsiHiddenProperties in Windows Installer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants