Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Microsoft.OpenApi Assembly No Longer Signed as of 1.6.18 #1796

Closed
wsugarman opened this issue Aug 27, 2024 · 5 comments · Fixed by #1800
Closed

Microsoft.OpenApi Assembly No Longer Signed as of 1.6.18 #1796

wsugarman opened this issue Aug 27, 2024 · 5 comments · Fixed by #1800
Assignees

Comments

@wsugarman
Copy link
Member

Describe the bug
As of version 1.6.18 in Nuget.org, the included Microsoft.OpenApi.dll assembly is no longer signed.

Expected behavior
The assemblies should be signed like in the previous package version.

@andrueastman
Copy link
Member

Thanks for raising this @wsugarman

Any chance you can take a look at this one @MaggieKimani1, @irvinesunday ?
I believe the culprit is this PR #1775 and it should probably look similar to microsoft/OpenAPI.NET.OData#558

@wsugarman
Copy link
Member Author

Thank you for the quick fix! I just want to confirm @andrueastman and @MaggieKimani1 that version 1.6.18 is ok to use?

@andrueastman
Copy link
Member

@wsugarman There should be a new update pretty soon with signed binaries. This should be out once #1802 is merged.

@MaggieKimani1
Copy link
Contributor

MaggieKimani1 commented Aug 30, 2024

@wsugarman v.1.6.19 is now available on NuGet for use with all the binaries signed. 🙂

@wsugarman
Copy link
Member Author

Great! Thank you so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants