Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unexplained inconsistency in barchart tutorial #10

Open
roseKQ opened this issue Dec 6, 2016 · 1 comment
Open

unexplained inconsistency in barchart tutorial #10

roseKQ opened this issue Dec 6, 2016 · 1 comment

Comments

@roseKQ
Copy link

roseKQ commented Dec 6, 2016

I have been trying to update the API to 1.3 - I managed to do this but had to change my values value from number to PrimitiveValue - It however is now not compatible with the d3 I had written (I had a working custom visual) using API version 1.2. I looked back over the barchart tutorial to see how this issue was dealt with, and found that there was an unexplained change not highlighted in the code from commit to commit.

In the building Bar Chart section;

Step 6. Adding Databound Objects to Property Pane - at this commit -

src/barchart.ts - line 26

value: number;

Step 7. Adding Tooltips to the Bar Chart - There is an undocumented change at this commit

src/barchart.ts - line 26

value: PrimitiveValue;

If you're using commits to highlight the changes made at each stage in a tutorial, it is unfair to boobytrap the tutorial by not highlighting or explaining all changes. I've had to revert back to API 1.2 until I figure out how to proceed.

@helen508light
Copy link
Contributor

has been resolved

@helen508light helen508light reopened this Jun 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants