[PT Run] [Settings] Additional Plugin Options: Allow description for checkbox

[htcfreek]

Description of the new feature / enhancement

For some additional plugin options it would be great to add a description subtitle. Then we can provide additional information to the user.

Scenario when this would be used?

An optional plugin setting that needs additional information that we need to provide to the user.

Supporting information

I think the class property can be null if now subtitle should be shown.

[htcfreek]

@crutkas
Can we give this a bit more priority. Some of the new WindowWalker settings name are a bit long. Having a subtitle would help here. (But I can't implement it, as it's a bit to complicated to me and touches winui code.)

cc: @niels9001

[htcfreek]

@crutkas
Can we give this a bit more priority. Some of the new WindowWalker settings name are a bit long. Having a subtitle would help here. (But I can't implement it, as it's a bit to complicated to me and touches winui code.)

cc: @niels9001

See screenshots in #16325.

[niels9001]

@htcfreek There's a CheckBoxWithDescription control in PowerToys.Settings.UI. That allows you to set the header and description. Does that help to solve this issue?

[htcfreek]

@niels9001
Technically no. The list of additional plugin options created dynamically. So we have to check for each element in the object if we need description or not. Additional this might touch SettingsUi.Library.
But if you asking for the user experience then definitely yes.

I can update wox code. But I don't find the settings code that has to be changed. And I don't know what has to be changed in xaml item template to select the checkbox control dynamically.

[htcfreek]

@niels901
Can you implement the feature in settings ui code? This would be great to have for v0.57.0 release as I worry that some of the new setting names will be to long when translated. 🤨

[crutkas]

Help me understand impact here. What does it look like currently if this wasn’t prioritized.

[htcfreek]

Help me understand impact here. What does it look like currently if this wasn’t prioritized.

I worry that some of the translated strings become to long for the ui. Or does the checkbox control has word wrap enable?

[crutkas]

It has word wrap. I don't think this would be too hard to implement as global results already has the secondary description

[crutkas]

@htcfreek why won't CheckBoxWithDescription control work?

[htcfreek]

@htcfreek why won't CheckBoxWithDescription control work?

The box work. But I can't implement it. I don't know how to change code that it works.

This file is easy to change:
https://github.com/microsoft/PowerToys/blob/main/src/settings-ui/Settings.UI.Library/PluginAdditionalOption.cs

But this file is my problem that I don't know how to change atm (@niels9001):
https://github.com/microsoft/PowerToys/blob/main/src/settings-ui/Settings.UI/Views/PowerLauncherPage.xaml#L252-L262

[niels9001]

@htcfreek You'd need to replace the CheckBox with the CheckBoxWithDescription control, and then bind it's Content to DisplayLabel and Description to another string (which isn't defined yet in PluginAdditionalOption.cs. Maybe we should move to public string Title and public string Description there?

[htcfreek]

@htcfreek You'd need to replace the CheckBox with the CheckBoxWithDescription control, and then bind it's Content to DisplayLabel and Description to another string (which isn't defined yet in PluginAdditionalOption.cs. Maybe we should move to public string Title and public string Description there?

What happened if description property of CheckBoxWithDescription is null? Not every setting needs a description.

[htcfreek]

Maybe we should move to public string Title and public string Description there?

Might be more work as all existing setting might be broken then. We shouldn't do that. But for description we can omit the word Display.

[htcfreek]

Let's wait with this issue until #16325 is merged.

[htcfreek]

@niels9001
I looked at the control you mentioned: https://github.com/microsoft/PowerToys/blob/main/src/settings-ui/Settings.UI/Controls/CheckBoxWithDescriptionControl.cs#L42

• Shouldn't we updated description in update method too? 🤔
• Is the whole control recreated on opening the page? (Then I would simply add an if else condition to add/not add the subtitle text box.)

[htcfreek]

@jaimecbernardo
Cam you please update issue state. thank you.

[htcfreek]

This is fixed with 0.57.0. Please head over to https://aka.ms/installpowertoys