-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PTRun][WindowWalker] Fails for computers where no Virtual Desktops have been created. #16896
Comments
@htcfreek , looks like we missed testing in some conditions ;) |
Good catch. I am confused. Is this a special system or did you disabled Virtual Desktops? Based on my testing at least one desktop must exist. Will look into this tomorrow. Please assign me. |
@jaimecbernardo Was this crash happening after or before showing the PT Run window? |
Thanks for picking it up. In order to simulate a PC that has never created Virtual desktops, remove these keys from the registry:
|
It's happening before showing the PT Run window. |
The question is what we return if this happens. "No desktop exist" or "desktop one" for each window? 🤔 |
Perhaps empty string for this case. |
Yes. This was an idea. It crashes when splitting the binary array from registry because the index that we calculate is invalid. So the idea is to set the desktop list to an empty one. |
@jaimecbernardo Or did you disabled virtual desktops with a gpo or something? |
This VM never used Virtual Desktops, so it's expected that the key is missing. |
I have fond the crash reason and the fix is nearly ready. It crashes when trying to selecting desktop one from the empty desktop list. 😅 I will request your review in the PR. |
Sent a debug build that contained this 😅 |
This is fixed with 0.57.0. Please head over to https://aka.ms/installpowertoys |
Microsoft PowerToys version
0.57.0-pre
Running as admin
Area(s) with issue?
PowerToys Run
Steps to reproduce
Start PowerToys Run in computers where no Virtual Desktops have been created yet, there's no registry key for the Virtual Desktops.
Window Walker is running into an error and not starting in these cases.
This is the current state building from main, likely after #16325
In order to simulate a PC that has never created Virtual desktops, remove these keys from the registry:
CurrentVirtualDesktop
from\HKEY_CURRENT_USER\Software\Microsoft\Windows\CurrentVersion\Explorer\SessionInfo\1\VirtualDesktops
VirtualDesktopIDs
from\HKEY_CURRENT_USER\Software\Microsoft\Windows\CurrentVersion\Explorer\VirtualDesktops
✔️ Expected Behavior
PowerToys Run starts normally.
❌ Actual Behavior
This message is shown:
This gets added to the PowerToys Run logs.
Other Software
No response
The text was updated successfully, but these errors were encountered: