-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Updater; Runner] Optimized notifications #2337
Comments
Would be nice to have a 'What's new' button in the toast, that will take you to the latest release notes. |
Or as a link if this would work. |
I think that should be part of OOBE for what is new on upgrade. This could be a combo as well |
We don't auto download and we show the same notification we are showing in the current version. |
Then I think the notification when a Update is available could be misunderstanding. |
What do you mean? |
I mean ready to install implies that the software has been downloaded. And when the user cut off network connection and tries to update, the update will fail. That's why I would write:
Or we can use the word "available":
|
@enricogior That we don't missunderstanding each other: What is the current message on metered connections? |
@htcfreek it's the same as when dowload updates is off, see https://user-images.githubusercontent.com/1828123/80097237-a4276580-8573-11ea-9181-319f613f10a1.png |
@yuyoyuppe What do you think on adding the title for the time dropdown or is that idea not relizable? |
@htcfreek, I don't think toast notifications support this unfortunately. |
Interesting. Because I have found this image at the ms docs. I think it is realized as bold text in the message. Great thing! Here have found a code example (Not tested by me!): https://automationsynd.github.io/sccm/2018/12/26/sccm-toasts.html |
@htcfreek oh, that's a great find! I'll add it. |
|
PT checks for the update once per 24 hours and shows you a corresponding notification if it's not already in your action center. Regarding the Snooze functionality for other toasts, I don't really have a preference either way, perhaps @enricogior or @crutkas could weight in?
Regarding the uninstall toasts, you probably seen some of the logic we've done previously for migration from/to MSI/MSIX, which isn't currently used, because we currently do not support MSIX (that might change in the future). For the current update flow, we do not uninstall the previous version explicitly, we install the new msi directly, and WiX toolset handles the detection and uninstallation of the previous version. We also do not report any errors ourselves, because a user will see a error which was generated by MSI itself. |
@yuyoyuppe Okay. |
For 0.17 we should be good as we are. We don't have a lot of time to test more changes, we can revisit it in 0.18 or more likely in 0.19. |
|
On metered connections we don't offer the possibility to auto download, we only notify the user that a new version is available and to visit the release page. |
I think on metered connections we shouldn't download anything.
The size information is an interesting idea. But my main intention is to say the user, that at the point of notify that an update is ready to install, we have nothing downloaded. (Please correct me if this is wrong.) That's what I mean with "is ready to install" could be misunderstanding. |
We don't say "ready to install" before downloading. |
@yuyoyuppe Have you used the default snooze button with an empty content attribute? Sample: |
@htcfreek hmm, we will add localization in the future, so reverting it seems like a wrong thing to do. I'd rather change the title to something like "You can snooze it to be reminded in:". @enricogior thoughts? |
@yuyoyuppe I wouldn't reverting it. You only must give the button a fixed name via the attribute. Then Windows won't translate. P. S.: I have more nice mocups, that I will comment later this day. One includs the update size. - Let me surprise you. 😉 |
@yuyoyuppe |
@htcfreek I meant giving a fixed name to implicitly localized button is akin to reverting localization 🙂 @enricogior ok, I'll fix it. |
Should we write "reminded again"? |
@yuyoyuppe Oops you were faster than me. Then we will let it without the word "again". |
@yuyoyuppe
|
@htcfreek, hmm, I don't think so. here's how the latest update toast looks: |
@yuyoyuppe Tomorrow I will do some tests when I rework my new mockup. |
@enricogior @yuyoyuppe: Sory for let you waiting. But here they are: The new layout mockups. These mockups should show what we can do/use. @yuyoyuppe: On my test notifications the footer with app name and time is shown. I have used the notification type "ToastGeneric". Changes made in this mockup
Creation of the notifications for this mockup
PT iconsThe PT icons are based on the new PT icon created by @enricogior and the icon team. (See PR #2289 and issue #1118.) The icons showing the message type are my own work and only samples. Code for the notificationsXML files for "Notification Visualizer" |
I like the larger icon, I don't like the idea of icon overlays, in particular I don't think the info and the warning overlays are necessary, they are not really providing useful information. |
@yuyoyuppe I have found an explanation why my notifications shows the footer with app name and the productively notifications doesn't shows that. The reason is that I use the appLogoOverride feature: https://docs.microsoft.com/en-us/windows/uwp/design/shell/tiles-and-notifications/adaptive-interactive-toasts#visual |
@enricogior An other idea
|
Yes. I'm not a big fan of the concept of changing icons color to describe state, it's not just a personal opinion, it's a matter of accessibility. |
@enricogior Do we open a new issue if we want to implement some of the new ideas or do we reopen the issue after the release of 0.17? I am asking because of the lable Resolution-Fix-Comitted. |
We open a new one, since this one has been fixed. |
Fixed in v.0.17 https://github.com/microsoft/PowerToys/releases |
Like suggested by @crutkas and me in PR #2141 we should optimize the updaters' toast notifications.
If you have further ideas please comment them.
It would be nice if someone of the other project contributors could create the necessary PRs.
⚠ Please add screenshots of the new notifications, so that other contributors don't have to run your code to see the changes.
Screenshot of the current toast notification:
1. Adding version numbers
The following texts are examples and the images are created with an image editing tool. If I have forgotten some texts feel free to also add them a version number.
a) update is available
b) update successfully installed
c) update failed
d) Old version detected
e) Uninstall old version failed
ℹ Here the version number is important that the user knows which version he has to uninstall.
2. Optimice button layout
I think we could optimize the message by adding an title for the time dropdown like this:
3. Metered connections
I don't known how we actually react on metered connections. But a notification like this would be a great idea:
4. Definition of "is ready to install"
In the update notify we have the following text:
An update to PowerToys is ready to install.
Is the update downloaded already when this notification gets shown or must text been like the following:
An Update to PowerToys is ready to download and install.
The text was updated successfully, but these errors were encountered: