Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Keyboard Manager] Editor UI still uses Windows 10 theme #28524

Closed
dillydylann opened this issue Sep 12, 2023 · 3 comments
Closed

[Keyboard Manager] Editor UI still uses Windows 10 theme #28524

dillydylann opened this issue Sep 12, 2023 · 3 comments
Assignees
@dillydylann
Labels
Help Wanted We encourage anyone to jump in on these and submit a PR. Idea-Enhancement New feature or request on an existing product Product-Keyboard Shortcut Manager Issues regarding Keyboard Shortcut Manager Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release.

Comments

@dillydylann
Copy link
Contributor

dillydylann commented Sep 12, 2023 •
edited
Loading

Description of the new feature / enhancement

The Keyboard Manager Editor UI currently uses the old Windows 10 design which makes it look out of place with Windows 11 and the rest of PowerToys. It should be updated to utilize the Fluent design language of Windows 11.

Scenario when this would be used?

Many users of Windows 11 and PowerToys want a consistent UX across all apps and utilities discussed as one of the goals in #891.

Supporting information

Originally, I didn't think about making this issue because it has been discussed in #2027 and #15870 in a similar way but that only talked about porting from code-behind to XAML or to WinUI 3 so the PR below wouldn't count for closing those issues. I only added this for better issue tracking.
@dillydylann dillydylann added the Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams label Sep 12, 2023
@dillydylann dillydylann mentioned this issue Sep 12, 2023
Merged
11 tasks
@crutkas crutkas added Idea-Enhancement New feature or request on an existing product Product-Keyboard Shortcut Manager Issues regarding Keyboard Shortcut Manager and removed Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams labels Sep 13, 2023
@crutkas
Copy link
Member

crutkas commented Sep 13, 2023

This isn't #15870 since this is staying on WinUI 2.8, not fully shift to 3, correct?

@crutkas crutkas added Help Wanted We encourage anyone to jump in on these and submit a PR. Status-In progress This issue or work-item is under development labels Sep 13, 2023
@dillydylann
Copy link
Contributor Author

@crutkas Yes, for now, it's using WinUI 2.8 because it's compatible with the current implementation.

@jaimecbernardo jaimecbernardo added Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed Status-In progress This issue or work-item is under development labels Nov 7, 2023
@stefansjfw
Copy link
Collaborator

The work associated with this issue has been released as part of the 0.76 sprint. Please update PowerToys to the latest. https://github.com/microsoft/PowerToys/releases

@ethanfangg ethanfangg moved this to ✅Done in 3. Help Wanted Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dillydylann dillydylann

Labels
Help Wanted We encourage anyone to jump in on these and submit a PR. Idea-Enhancement New feature or request on an existing product Product-Keyboard Shortcut Manager Issues regarding Keyboard Shortcut Manager Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
3. Help Wanted
Status: ✅Done
Milestone
No milestone
Development

No branches or pull requests
4 participants
@crutkas @dillydylann @jaimecbernardo @stefansjfw