PowerToys Run Shell integration; default terminal profile is not used

[ArthurHuyghe]

Microsoft PowerToys version

0.74.0

Installation method

WinGet, Chocolatey

Running as admin

Yes

Area(s) with issue?

PowerToys Run

Steps to reproduce

Launch PowerToys Run and enter a Shell command like ping github.com while the Shell integration is set to use windows terminal.

✔️ Expected Behavior

When a command like ping github.com is launche₫ with PowerToys Run, it should open a new instance of Windows Terminal with the default profile. Or there should be a possibility to set the profile you want to use.

❌ Actual Behavior

It opened a terminal instance with the legacy powershell 5.

Other Software

Windows Terminal version: 1.18.2681.0

[htcfreek]

This is caused by the following code: https://github.com/microsoft/PowerToys/blob/main/src/modules/launcher/Plugins/Microsoft.Plugin.Shell/Main.cs#L223-L230

[htcfreek]

From what I have tested using the default profile is impossible because of two problems (keeping window open setting and microsoft/terminal#16062)

But I can rework the behavior that the user selects the shell (e.g. PowerShell 7) and has a checkbox to run Shells (cmd, ps 5, pwsh 7) in WT. Does that sounds good to you?

cc: @jaimecbernardo

[ArthurHuyghe]

@htcfreek, thanks for the quick response. Your suggestion sounds like a good idea. However, maybe this is something you could use to make this work; https://learn.microsoft.com/nl-be/windows/terminal/command-line-arguments?tabs=powershell#open-a-new-profile-instance
In this way you could set a profile to use when executing the shell command. Maybe this opens a possibilty to select a profile to use for executing the shell commands in the terminal.

[htcfreek]

@htcfreek, thanks for the quick response. Your suggestion sounds like a good idea. However, maybe this is something you could use to make this work; https://learn.microsoft.com/nl-be/windows/terminal/command-line-arguments?tabs=powershell#open-a-new-profile-instance
In this way you could set a profile to use when executing the shell command. Maybe this opens a possibilty to select a profile to use for executing the shell commands in the terminal.

Two problems:

1. This does not support "keep window open".
2. This requires v1.19 of WT which is a prerelease.

[ArthurHuyghe]

I did not in fact needed v1.19 to be able to use wt -w -1 nt which opens a new tab in a new window with the default profile. I'm currently running v1.18.2681.0. installed using winget.

However I do not know if why it does not support "keep window open" and if its something we could change.

[htcfreek]

@ArthurHuyghe

1. I agree that using the default profile is possible without having v1.19.
2. The --appendCommandline feature from WT 1.19 would help to use specific profiles for executing a command. (Currently we need to start powershell.exe in the default profile if it is not the default.)
3. I have opened an issue for the "keep window open" feature.

The main question is how we can implement it in a simple and user friendly way. (I plan to implement #28889 later if WT 1.19 is stable, if I remove an dropdown item settings will crash and the "keep shell open" setting isn't working in all WT scenarios.)

[ArthurHuyghe]

@htcfreek Great! Then we can only wait until they release v1.19.

Maybe you could make a dropdown allowing the user to choose between the default profile (by using wt -w -1 nt perhaps 🤷‍♂️) or between one of the suggestion you mentioned in your first comment.

[htcfreek]

This fix/feature is included in the new 0.75.0 release of PowerToys.