Text Extractor: open settings is buggy

[Jay-o-Way]

Microsoft PowerToys version

0.80.0

Installation method

PowerToys auto-update

Running as admin

None

Area(s) with issue?

TextExtractor

Steps to reproduce

Open Text Extractor. Click the "⚙️" (settings) button.

✔️ Expected Behavior

Settings opens on the right page

❌ Actual Behavior

In 0.80, this opens the Dashboard page, even though PowerOCR is used in the SettingsWindowNameToString(window) method. In a PR i'm working on, something is crashing.

Other Software

No response

[github-actions]

Hi I'm an AI powered bot that finds similar issues based off the issue title.

Please view the issues below to see if they solve your problem, and if the issue describes your problem please consider closing this one and thumbs upping the other issue to help us prioritize it. Thank you!

Open similar issues:

• Text Extractor Crashes PowerToys (#30664), similarity score: 0.81

Closed similar issues:

• Control Panel crash when opening TextExtractor settings (#30263), similarity score: 0.80
• Text Extractor not working (#24299), similarity score: 0.75

Note: You can give me feedback by thumbs upping or thumbs downing this comment.

[davidegiacometti]

Same issue can be reproduced while trying to open Text Extractor from The PT Run result.

[Jay-o-Way]

Same issue can be reproduced while trying to open Text Extractor from The PT Run result.

I think that's the opposite "direction" of what I meant?

This works fine for me.

[davidegiacometti]

Oops! I meant open Text Extractor settings from the context button, not the utility.

These aren't aligned: PowerOCR and PowerOcr.
This could also be improved! 😄

PowerToys/src/common/Common.UI/SettingsDeepLink.cs

Lines 35 to 82 in 3b82ce9

	private static string SettingsWindowNameToString(SettingsWindow value)
	{
	switch (value)
	{
	case SettingsWindow.Overview:
	return "Overview";
	case SettingsWindow.Awake:
	return "Awake";
	case SettingsWindow.ColorPicker:
	return "ColorPicker";
	case SettingsWindow.FancyZones:
	return "FancyZones";
	case SettingsWindow.Run:
	return "Run";
	case SettingsWindow.ImageResizer:
	return "ImageResizer";
	case SettingsWindow.KBM:
	return "KBM";
	case SettingsWindow.MouseUtils:
	return "MouseUtils";
	case SettingsWindow.PowerRename:
	return "PowerRename";
	case SettingsWindow.FileExplorer:
	return "FileExplorer";
	case SettingsWindow.ShortcutGuide:
	return "ShortcutGuide";
	case SettingsWindow.VideoConference:
	return "VideoConference";
	case SettingsWindow.Hosts:
	return "Hosts";
	case SettingsWindow.MeasureTool:
	return "MeasureTool";
	case SettingsWindow.PowerOCR:
	return "PowerOCR";
	case SettingsWindow.RegistryPreview:
	return "RegistryPreview";
	case SettingsWindow.CropAndLock:
	return "CropAndLock";
	case SettingsWindow.EnvironmentVariables:
	return "EnvironmentVariables";
	case SettingsWindow.Dashboard:
	return "Dashboard";
	default:
	{
	return string.Empty;
	}
	}
	}

PowerToys/src/settings-ui/Settings.UI/SettingsXAML/App.xaml.cs

Lines 477 to 512 in 3b82ce9

	public static Type GetPage(string settingWindow)
	{
	switch (settingWindow)
	{
	case "Dashboard": return typeof(DashboardPage);
	case "Overview": return typeof(GeneralPage);
	case "AlwaysOnTop": return typeof(AlwaysOnTopPage);
	case "Awake": return typeof(AwakePage);
	case "CmdNotFound": return typeof(CmdNotFoundPage);
	case "ColorPicker": return typeof(ColorPickerPage);
	case "FancyZones": return typeof(FancyZonesPage);
	case "FileLocksmith": return typeof(FileLocksmithPage);
	case "Run": return typeof(PowerLauncherPage);
	case "ImageResizer": return typeof(ImageResizerPage);
	case "KBM": return typeof(KeyboardManagerPage);
	case "MouseUtils": return typeof(MouseUtilsPage);
	case "MouseWithoutBorders": return typeof(MouseWithoutBordersPage);
	case "PowerRename": return typeof(PowerRenamePage);
	case "QuickAccent": return typeof(PowerAccentPage);
	case "FileExplorer": return typeof(PowerPreviewPage);
	case "ShortcutGuide": return typeof(ShortcutGuidePage);
	case "PowerOcr": return typeof(PowerOcrPage);
	case "VideoConference": return typeof(VideoConferencePage);
	case "MeasureTool": return typeof(MeasureToolPage);
	case "Hosts": return typeof(HostsPage);
	case "RegistryPreview": return typeof(RegistryPreviewPage);
	case "PastePlain": return typeof(PastePlainPage);
	case "Peek": return typeof(PeekPage);
	case "CropAndLock": return typeof(CropAndLockPage);
	case "EnvironmentVariables": return typeof(EnvironmentVariablesPage);
	default:
	// Fallback to Dashboard
	Debug.Assert(false, "Unexpected SettingsWindow argument value");
	return typeof(DashboardPage);
	}
	}

[jaimecbernardo]

Oops! I meant open Text Extractor settings from the context button, not the utility.

These aren't aligned: PowerOCR and PowerOcr. This could also be improved! 😄

PowerToys/src/common/Common.UI/SettingsDeepLink.cs

Lines 35 to 82 in 3b82ce9

	private static string SettingsWindowNameToString(SettingsWindow value)
	{
	switch (value)
	{
	case SettingsWindow.Overview:
	return "Overview";
	case SettingsWindow.Awake:
	return "Awake";
	case SettingsWindow.ColorPicker:
	return "ColorPicker";
	case SettingsWindow.FancyZones:
	return "FancyZones";
	case SettingsWindow.Run:
	return "Run";
	case SettingsWindow.ImageResizer:
	return "ImageResizer";
	case SettingsWindow.KBM:
	return "KBM";
	case SettingsWindow.MouseUtils:
	return "MouseUtils";
	case SettingsWindow.PowerRename:
	return "PowerRename";
	case SettingsWindow.FileExplorer:
	return "FileExplorer";
	case SettingsWindow.ShortcutGuide:
	return "ShortcutGuide";
	case SettingsWindow.VideoConference:
	return "VideoConference";
	case SettingsWindow.Hosts:
	return "Hosts";
	case SettingsWindow.MeasureTool:
	return "MeasureTool";
	case SettingsWindow.PowerOCR:
	return "PowerOCR";
	case SettingsWindow.RegistryPreview:
	return "RegistryPreview";
	case SettingsWindow.CropAndLock:
	return "CropAndLock";
	case SettingsWindow.EnvironmentVariables:
	return "EnvironmentVariables";
	case SettingsWindow.Dashboard:
	return "Dashboard";
	default:
	{
	return string.Empty;
	}
	}
	}

PowerToys/src/settings-ui/Settings.UI/SettingsXAML/App.xaml.cs

Lines 477 to 512 in 3b82ce9

	public static Type GetPage(string settingWindow)
	{
	switch (settingWindow)
	{
	case "Dashboard": return typeof(DashboardPage);
	case "Overview": return typeof(GeneralPage);
	case "AlwaysOnTop": return typeof(AlwaysOnTopPage);
	case "Awake": return typeof(AwakePage);
	case "CmdNotFound": return typeof(CmdNotFoundPage);
	case "ColorPicker": return typeof(ColorPickerPage);
	case "FancyZones": return typeof(FancyZonesPage);
	case "FileLocksmith": return typeof(FileLocksmithPage);
	case "Run": return typeof(PowerLauncherPage);
	case "ImageResizer": return typeof(ImageResizerPage);
	case "KBM": return typeof(KeyboardManagerPage);
	case "MouseUtils": return typeof(MouseUtilsPage);
	case "MouseWithoutBorders": return typeof(MouseWithoutBordersPage);
	case "PowerRename": return typeof(PowerRenamePage);
	case "QuickAccent": return typeof(PowerAccentPage);
	case "FileExplorer": return typeof(PowerPreviewPage);
	case "ShortcutGuide": return typeof(ShortcutGuidePage);
	case "PowerOcr": return typeof(PowerOcrPage);
	case "VideoConference": return typeof(VideoConferencePage);
	case "MeasureTool": return typeof(MeasureToolPage);
	case "Hosts": return typeof(HostsPage);
	case "RegistryPreview": return typeof(RegistryPreviewPage);
	case "PastePlain": return typeof(PastePlainPage);
	case "Peek": return typeof(PeekPage);
	case "CropAndLock": return typeof(CropAndLockPage);
	case "EnvironmentVariables": return typeof(EnvironmentVariablesPage);
	default:
	// Fallback to Dashboard
	Debug.Assert(false, "Unexpected SettingsWindow argument value");
	return typeof(DashboardPage);
	}
	}

This is exactly what I suspected. It was changed for DSC and impacted these.

[Jay-o-Way]

This is exactly what I suspected. It was changed for DSC and impacted these.

I'll believe you 👍 Something you would like to pick up or better for somebody else?

[jaimecbernardo]

This is exactly what I suspected. It was changed for DSC and impacted these.

I'll believe you 👍 Something you would like to pick up or better for somebody else?

I'm doing it. Thank you :)

[jaimecbernardo]

This one should be fixed with the 0.80.1 hotfix. Please update to the latest version: https://github.com/microsoft/PowerToys/releases