Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[KBM] Buttons style #6664

Closed
Jay-o-Way opened this issue Sep 16, 2020 · 5 comments
Closed

[KBM] Buttons style #6664

Jay-o-Way opened this issue Sep 16, 2020 · 5 comments
Labels
Area-Quality Stability, Performance, Etc. Area-User Interface things that regard UX for PowerToys External Dependency-WinUI 3 Dependency on WinUI Product-Keyboard Shortcut Manager Issues regarding Keyboard Shortcut Manager Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.
Milestone
Suggested Enhance...

Comments

@Jay-o-Way
Copy link
Collaborator

Jay-o-Way commented Sep 16, 2020 •
edited
Loading

The looks of Windows 10, or WinUI, is very slim and flat. not slim and fat I took another look and I see that these Type buttons look different from other buttons.
Also: OK and Cancel

image
@ghost ghost added the Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams label Sep 16, 2020
@Jay-o-Way Jay-o-Way changed the title I've tried to remap it, but under the remap key, I can only press 1 key at a time, so I'm unable to remap combination keys. If I use remap shortcut, I'll be able to select 2 key combinations, but the targeted app doesn't seem to be able to target a function like Task View. Am I doing it wrongly? Buttons in the Keyboard Manager window look different - even less recognisable as buttons Sep 16, 2020
@arjunbalgovind
Copy link
Contributor

I think ideally we would fix this by adding accent colors to all the buttons? We also have a tech debt issue for adding rounded corners as well. @saahmedm FYI

@Jay-o-Way
Copy link
Collaborator Author

Is this not done with Styles? Don't know if you are using C#, C++ or XAML to build this?

@saahmedm saahmedm added Idea-Enhancement New feature or request on an existing product Product-Keyboard Shortcut Manager Issues regarding Keyboard Shortcut Manager and removed Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams labels Sep 17, 2020
@saahmedm saahmedm added this to the Suggested Enhancements milestone Sep 17, 2020
@arjunbalgovind
Copy link
Contributor

@Jay-o-Way yes, this would be done with styles, but currently the entire KBM UI is in code behind in a C++ XAML Island, so adding styles requires a lot of redundant code. Once we migrate to WinUI3 and XAML this would be much easier.

@Jay-o-Way Jay-o-Way changed the title Buttons in the Keyboard Manager window look different - even less recognisable as buttons Buttons in the Keyboard Manager window look different Sep 17, 2020
@Jay-o-Way Jay-o-Way mentioned this issue Oct 1, 2020
Closed
@enricogior enricogior added Area-User Interface things that regard UX for PowerToys Area-Quality Stability, Performance, Etc. External Dependency-WinUI 3 Dependency on WinUI and removed Idea-Enhancement New feature or request on an existing product labels Jan 10, 2021
@enricogior enricogior changed the title Buttons in the Keyboard Manager window look different [KBM] Buttons style Jan 10, 2021
@Jay-o-Way Jay-o-Way mentioned this issue Aug 22, 2021
Merged
10 tasks
@Jay-o-Way
Copy link
Collaborator Author

I guess this can be closed against larger issue #2027, right?

@Aaron-Junker
Copy link
Collaborator

I guess this can be closed against larger issue #2027, right?

@Jay-o-Way Yes I also think so

@Aaron-Junker Aaron-Junker added the Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing. label Aug 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-Quality Stability, Performance, Etc. Area-User Interface things that regard UX for PowerToys External Dependency-WinUI 3 Dependency on WinUI Product-Keyboard Shortcut Manager Issues regarding Keyboard Shortcut Manager Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.
Projects
None yet
Milestone
Suggested Enhancements
Development

No branches or pull requests
5 participants
@enricogior @arjunbalgovind @Aaron-Junker @saahmedm @Jay-o-Way