Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Alt+F4 doesn't close powertoys Settings app #7243

Closed
asklar opened this issue Oct 12, 2020 · 12 comments
Closed

Alt+F4 doesn't close powertoys Settings app #7243

asklar opened this issue Oct 12, 2020 · 12 comments
Labels
External Dependency This bug or feature isn't resolved, but it's following an external work item. Issue-Bug Something isn't working Product-Settings The standalone PowerToys Settings application Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release.

Comments

@asklar
Copy link
Member

asklar commented Oct 12, 2020

Alt+F4 should close the app
@asklar asklar added the Issue-Bug Something isn't working label Oct 12, 2020
@ghost ghost added the Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams label Oct 12, 2020
@crutkas
Copy link
Member

crutkas commented Oct 12, 2020

I can actually recreate this on 0.23.2.

Double clicked on systray to bring up settings. It seems to work if you don't engage the island (aka titlebar). second you give focus to the island, it breaks.

@crutkas crutkas added Product-Settings The standalone PowerToys Settings application and removed Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams labels Oct 12, 2020
@davidegiacometti
Copy link
Collaborator

Maybe related to this? microsoft/microsoft-ui-xaml#2408

@crutkas crutkas added the External Dependency This bug or feature isn't resolved, but it's following an external work item. label Oct 20, 2020
@crutkas crutkas added the Status-Blocked We can't make progress due to a dependency or issue label Oct 20, 2020
@seonglae
Copy link

seonglae commented Jun 28, 2021 •
edited
Loading

This is annoying bug

@jaimecbernardo
Copy link
Collaborator

This is still an issue with the new style. Just verified it.

@crutkas
Copy link
Member

crutkas commented Aug 30, 2021

This is an xaml island issue, upgrading to unpackaged winui3 app will solve this.

@crutkas
Copy link
Member

crutkas commented Oct 13, 2021

So this looks to be fixed on Windows 11 but not downlevel. This ultimately will be resolved e2e for everyone when that happens.

Tested on 22474, but should be on 22000 as well.

@franky920920 franky920920 mentioned this issue Oct 14, 2021
Closed
1 task
@SvendK SvendK mentioned this issue Jan 13, 2022
Closed
1 task
@SvendK
Copy link

SvendK commented Jan 13, 2022 •
edited
Loading

Still an issue. I have no idea what an "island" is (in computer science), but I can confirm in Win10 21H1 build 19043 that if I just click the tray icon, waits for it to open, alt-tab to the window (which for some reason don't get focus) and then alt-F4, then it closes. If I click in the window with the mouse, alt-F4 is ignored. Even minimizing and then alt-tabbing again, alt-F4 is still ignored.

Here's two bug report files if you need it.

PowerToysReport_2022-01-13-11-36-10.zip

PowerToysReport_2022-01-13-11-49-14.zip

@crutkas
Copy link
Member

crutkas commented Jan 13, 2022

https://docs.microsoft.com/en-us/windows/apps/desktop/modernize/xaml-islands. Here we're referring to 1 framework hosting another UX framework. It is how we're getting a modern UX but ability to do lower level stuff that we need access to.

Ultimately, Win10 will still have the issue until we roll the entire settings app to WinUI 3 app which is a requirement for ARM64. We need 3.1 to provide multi-window and elevation

@crutkas
Copy link
Member

crutkas commented Jan 13, 2022

Ultimately, due to that, we could just dup this against that. #6715

@Jay-o-Way Jay-o-Way mentioned this issue Jan 21, 2022
Closed
@crutkas crutkas added Status-In progress This issue or work-item is under development and removed Status-Blocked We can't make progress due to a dependency or issue labels Apr 14, 2022
@crutkas
Copy link
Member

crutkas commented Apr 14, 2022

This should be fixed with the transition to WinUI 3 work that @ stefansjfw is working on this iteration

@crutkas
Copy link
Member

crutkas commented Apr 29, 2022

just verified this is working correctly now

@crutkas crutkas added Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed Status-In progress This issue or work-item is under development labels Apr 29, 2022
@Aaron-Junker
Copy link
Collaborator

This got implemented in the 0.58 update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
External Dependency This bug or feature isn't resolved, but it's following an external work item. Issue-Bug Something isn't working Product-Settings The standalone PowerToys Settings application Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@crutkas @SvendK @asklar @davidegiacometti @jaimecbernardo @seonglae @Aaron-Junker