Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FZ Editor] Multiple custom layouts list is not scrollable #738

Closed
rehsouna11 opened this issue Nov 18, 2019 · 5 comments
Closed

[FZ Editor] Multiple custom layouts list is not scrollable #738

rehsouna11 opened this issue Nov 18, 2019 · 5 comments
Labels
Area-Accessibility Issues related to accessibility Area-Quality Stability, Performance, Etc. FancyZones-Editor Issue revolving the FancyZone Editor Issue-Bug Something isn't working Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release.

Comments

@rehsouna11
Copy link

rehsouna11 commented Nov 18, 2019

Steps to reproduce

when multiple custom layouts are saved, the apply button gets out of the screen, no scrolling is allowed, and the window height is longer than the screen size

Expected behavior

the scroll bar is shown

Actual behavior

The layouts list goes beyond the screen height and they are no longer accessible

Screenshots

image_14

@enricogior enricogior added Issue-Bug Something isn't working Product-FancyZones Refers to the FancyZones PowerToy FancyZones-Editor Issue revolving the FancyZone Editor labels Nov 18, 2019
@crutkas crutkas added the Area-Quality Stability, Performance, Etc. label Feb 28, 2020
@crutkas crutkas modified the milestone: 20.03 release Feb 28, 2020
@crutkas
Copy link
Member

crutkas commented Feb 28, 2020

i feel like this is a single attribute of XAML change

@enricogior
Copy link
Contributor

For small screens, the editor was unusable even with two rows (the edit and apply buttons ended up out of the screen because the editor didn't scale and had a fixed size), so we made a fix that at the time was approved only for the small screens case, but it looks good on large screen as well, instead of 3 columns, it uses 5 columns, beside also scaling a little bit down.

Commit for the small screen fix 425a418

Annotation 2020-02-29 001643

@enricogior
Copy link
Contributor

i feel like this is a single attribute of XAML change

When I made the fix for small screens, I gave it a try and added the scroll bar as well but it broke some other logic, I didn't spend too much time on it, so it may be a simple fix, but it requires more than just one attribute change.

@enricogior enricogior changed the title Multiple custom layouts list is not scrollable [FancyZones Editor] Multiple custom layouts list is not scrollable May 1, 2020
@enricogior enricogior removed the Product-FancyZones Refers to the FancyZones PowerToy label May 18, 2020
@enricogior enricogior changed the title [FancyZones Editor] Multiple custom layouts list is not scrollable [FZ Editor] Multiple custom layouts list is not scrollable May 24, 2020
@crutkas crutkas added the Area-Accessibility Issues related to accessibility label Sep 8, 2020
@crutkas
Copy link
Member

crutkas commented Sep 8, 2020

while doubtful, feel we should still try to get in the release here

@crutkas crutkas added the Status-In progress This issue or work-item is under development label Oct 29, 2020
@crutkas
Copy link
Member

crutkas commented Oct 29, 2020

This is dependent on the Multi-mon PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Accessibility Issues related to accessibility Area-Quality Stability, Performance, Etc. FancyZones-Editor Issue revolving the FancyZone Editor Issue-Bug Something isn't working Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Development

No branches or pull requests

3 participants