Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FZ Editor] Displaying the monitors layout #8104

Open
ivan100sic opened this issue Nov 18, 2020 · 6 comments
Open

[FZ Editor] Displaying the monitors layout #8104

ivan100sic opened this issue Nov 18, 2020 · 6 comments
Labels
FancyZones-Editor Issue revolving the FancyZone Editor Priority-3 Bug that is low priority Product-FancyZones Refers to the FancyZones PowerToy

Comments

@ivan100sic
Copy link
Contributor

📝 Provide a description of the new feature

PT version: 613d1fd

When using the new multi-monitor FancyZones editor #6562, the monitors should be drawn similarly to how they're drawn on the Windows 10 Display settings page. Since changing this impacts the UI perhaps it should be done after #6899 is merged.

@ghost ghost added Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams FancyZones-Editor Issue revolving the FancyZone Editor Product-FancyZones Refers to the FancyZones PowerToy labels Nov 18, 2020
@ivan100sic
Copy link
Contributor Author

There would be two approaches to drawing these monitor previews.

One would be to change the container from horizontal to vertical when we detect vertical orientations. This one should be easier to code, but it would be limited to horizontal/vertical layouts.

The other would be to create some kind of a canvas and draw them there. Now I'm not exactly sure how to do this but we can give it a try. For that, it would make sense to get physical pixel coordinates for each monitor, just like Windows does in the Display settings.

@enricogior
Copy link
Contributor

@niels9001
when you work on the updated UI for the editor, let's chat on how/where we should put the multi monitor UI.

@enricogior enricogior added Priority-3 Bug that is low priority and removed Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams labels Nov 20, 2020
@enricogior enricogior removed the Product-FancyZones Refers to the FancyZones PowerToy label Dec 25, 2020
@enricogior enricogior changed the title FancyZones editor - displaying the monitor layout [FZ Editor] Displaying the monitors layout Jan 10, 2021
@dedavis6797
Copy link
Contributor

@niels9001 @SeraphimaZ Has this already been resolved?

@niels9001
Copy link
Contributor

@dedavis6797 Nope.

What is the main benefit of this? To recognize which screen is which?

@dedavis6797
Copy link
Contributor

I'm not sure myself. I actually misread the description and didn't catch the full context on what was being requested here, but I understand now. This's just looking to draw the monitors in the editor at the same orientation/positions as they're set in the Windows Display settings.

I guess I can seem some benefit to this, but I agree this should still be a rather low priority. I just wanted to get a better understanding on when this would land since it keeps getting punted.

@SeraphimaZykova
Copy link
Collaborator

It's for recognizing which screen is which when they're aligned vertically. Some users find it disturbing when they see monitors not in the same way as it is in the system settings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FancyZones-Editor Issue revolving the FancyZone Editor Priority-3 Bug that is low priority Product-FancyZones Refers to the FancyZones PowerToy
Projects
None yet
Development

No branches or pull requests

6 participants