Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FZ Editor] Crash when creating a new layout #9396

Closed
enricogior opened this issue Feb 1, 2021 · 3 comments
Closed

[FZ Editor] Crash when creating a new layout #9396

enricogior opened this issue Feb 1, 2021 · 3 comments
Labels
FancyZones-Editor Issue revolving the FancyZone Editor Issue-Bug Something isn't working Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release. Severity-High Bugs that we consider a blocking issue for release (crashes stuff outside of PT)

Comments

@enricogior
Copy link
Contributor

The new FZ Editor 646d61b has a rare crashing bug when creating a new layout.
Repro steps:

  • open the editor and click on "+ Create new layout"
  • click on "Create" (it doesn't matter if you choose Grid or Canvas)

Result: the editor crashes.
If the problem presents itself, it reproduces 100% of the times. Restarting PowerToys or Windows doesn't make any change. Re-installing PT or running a local build doesn't make any difference.
It happens on both .NET Core 3.1.10 and 3.1.11.

Description: The process was terminated due to an unhandled exception.
Exception Info: System.ArgumentOutOfRangeException: Specified argument was out of the range of valid values. (Parameter 'index')
   at System.Windows.Media.VisualCollection.get_Item(Int32 index)
   at System.Windows.Media.Visual.InternalGet2DOr3DVisualChild(Int32 index)

Full event log call stack attached.

event log.txt

@enricogior enricogior added Issue-Bug Something isn't working FancyZones-Editor Issue revolving the FancyZone Editor Severity-High Bugs that we consider a blocking issue for release (crashes stuff outside of PT) Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams and removed Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams labels Feb 1, 2021
@crutkas
Copy link
Member

crutkas commented Feb 1, 2021

dotnet/roslyn#17232 has a very close call stack

@crutkas
Copy link
Member

crutkas commented Feb 1, 2021

none of my computers can repro

thoughts:

  1. move Hide() to either top or bottom of method. The call is nested inside an area that is messing with data contexts.
  2. Wrap the Hide in a dispatcher.invoke
  3. what happens if we try/catch the hide? The call stack looks like it is getting into some type of recursive tree and fails.

@enricogior
Copy link
Contributor Author

  1. already tried
  2. already tried
  3. I tried to catch and call again Hide() inside the catch... it worked, no idea why, but it doesn't crash a second time.

@crutkas crutkas added the Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release. label Feb 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FancyZones-Editor Issue revolving the FancyZone Editor Issue-Bug Something isn't working Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release. Severity-High Bugs that we consider a blocking issue for release (crashes stuff outside of PT)
Projects
None yet
Development

No branches or pull requests

2 participants