Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Needs Feedback] Preview Pane - What should be on-by-default (Monaco preview) #9803

Closed
Aaron-Junker opened this issue Feb 19, 2021 · 11 comments
Labels
Needs-Community Feedback We need additional help with how something should act / look

Comments

@Aaron-Junker
Copy link
Collaborator

Community question:

So if we would implement a preview functionality in windows explorer for developer files(#1527), what of the following options would be the best for you?

  1. The user can choose in the installer for which file extensions it should get activated.
  2. All 126 file extensions get activated
  3. Only file extensions get activated that you had on your computer before
  4. Only common file extensions get activated

Please note, that after the installation of PT you can still deactivate/activate certain file types. It's just the default settings we talking about.

Also let other feedback here for this feature if you want.

Thank you for your thoughts on this.

@Aaron-Junker Aaron-Junker added Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams Needs-Community Feedback We need additional help with how something should act / look and removed Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams labels Feb 19, 2021
@Aaron-Junker Aaron-Junker changed the title [Needs Community help] Kind of developer file preview [Needs Community Feedback] Kind of developer file preview Feb 19, 2021
@Aaron-Junker
Copy link
Collaborator Author

@crutkas Could we pin this?

@crutkas
Copy link
Member

crutkas commented Feb 19, 2021

why not just activate all 126 by default and allow people to opt-out, these are all dev-ish focused files and limited to only preview pane

@crutkas crutkas pinned this issue Feb 19, 2021
@crutkas crutkas changed the title [Needs Community Feedback] Kind of developer file preview [Needs Feedback] Preview Pane - What should be on-by-default (Monaco preview) Feb 19, 2021
@htcfreek
Copy link
Collaborator

htcfreek commented Feb 19, 2021

We could add a general button to opt-out of all exts in one step and a listview where the user can opt-out each ext itself. Then we should be fine.

[x] Enable preview of dev files
    [x] enable ext1
    [ ] enable ext2
    [x] enable ext3
    ...

@Aaron-Junker
Copy link
Collaborator Author

why not just activate all 126 by default and allow people to opt-out, these are all dev-ish focused files and limited to only preview pane

But imagine you have a new coputer whee none of this 128 file extensions are registred. That means we must add 356 new registry keys (you need 2 for a file extension) and their subkeys. This are many keys.

@richsidney
Copy link

I think there are certain file types that make sense to preview, such as .log, .config, etc. There are others that don't help at all.

I suggest the following:

  1. Allow the user to choose during installation whether to enable any that aren't already enabled.
  2. If the user chooses yes, then display a list of common extensions, and preselect "reasonable" ones to enable.
  3. Provide a simple settings page that allows these to set/reset.

Note that the default extension selector used by windows when it asks is useless, because the extensions are displayed without any filtering or additional descriptions as to the extension's purpose, so don't do that.

@crutkas
Copy link
Member

crutkas commented Feb 20, 2021

During install won’t be a near term item.

@htcfreek
Copy link
Collaborator

During install won’t be a near term item.

But then we possibly override the existing settings and handlers. Then we shouldn't enable one of them by default.

@Jay-o-Way
Copy link
Collaborator

Jay-o-Way commented Mar 20, 2021

Personal thought

  1. Is too soon
  2. Sounds easy from user pov, but less simple from dev pov. as Aaron mentioned.
  3. Sounds like a smart balance 👍🏻
  4. Sounds good too, but how do we define "common" and where is the threshold?

Asides from these points: can/will they be grouped by category? Then we could even give every group (of check boxes) a "master" check box.
If it turns out that the best time for the first choice would be at install time, then we could use these categories to make an initial selection. Could use some of the logic from point 3 and/or 4 to have the most "useful" checked at first. Something like

  • Category A (30)
  • Category B (25)
  • ...
  • Category X (3)

@byamagata
Copy link

I dont mind having all extensions activated for it.
I like the idea of common ones being activated (eg: .cs, .json, .log, .config)
I also dont mind going through a long list and activating which ones I would want, as long as that list is searchable to some extent. Looking forward to this!

@crutkas
Copy link
Member

crutkas commented Mar 30, 2021

FYI thing to remember here also is we're only doing preview pane. Default app launching will be retained

@crutkas
Copy link
Member

crutkas commented Apr 2, 2021

Closing. Think it is all on by default, allow setting pane to turn off

@crutkas crutkas closed this as completed Apr 2, 2021
@crutkas crutkas unpinned this issue Apr 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs-Community Feedback We need additional help with how something should act / look
Projects
None yet
Development

No branches or pull requests

6 participants