Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Run][Plugin Manager] Additional settings: Definition of controls for additional settings #9934

Closed
htcfreek opened this issue Feb 26, 2021 · 2 comments
Labels
Area-User Interface things that regard UX for PowerToys Idea-Enhancement New feature or request on an existing product Run-Plugin Manager Issues with the PowerToys Run plugin manager

Comments

@htcfreek
Copy link
Collaborator

htcfreek commented Feb 26, 2021

📝 Provide a description of the new feature

We have now implemented a plugin management for PT Run into the settings ux (PR #9872; Issue #5273). This includes the option to define additional settings (like disable drive detection warning) for each plugin.

image

For the first step we agreed, that we do this technically by defining an array of check boxes, save it in PT Runs' settings file and that the rendering of the settings is taken by the settings app. This is not really flexible and in the future we might have plugins that needs other ux controls than a checkbox. (Example: Websearch plugin with selection of search provider.) The described problem can also concern new built-in plugins.

I think we should ...

  • allow more types of controls.
  • move the definition of the elements out of PT Runs' settings file.
  • strict define how the configuration file for the additional settings is formatted.

This is an example how the configuration file can look like in xml format:

<settingsGroup name="Result settings">
<checkbox name="example" default="on" settingsJsonString="ShowExampleResult" />
<radioGroup name="Show results of type" defaultRadio="1" settingsJsonString="ShowGameResult">
<radio order=1 name="all" description="example"/>
<radio order=2 name="games only" description="example"/>
</radioGroup>
</settingsGroup>

This is a remaining enhancement idea form issue #9655.

If you'd like to see this feature implemented, add a 👍 reaction to this post.

@htcfreek htcfreek added Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams Area-User Interface things that regard UX for PowerToys Idea-Enhancement New feature or request on an existing product Run-Plugin Manager Issues with the PowerToys Run plugin manager labels Feb 26, 2021
@crutkas
Copy link
Member

crutkas commented May 13, 2021

This needs to be directly driven by requirements versus hypothetical.

@crutkas crutkas closed this as completed May 13, 2021
@crutkas crutkas removed the Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams label May 13, 2021
@htcfreek
Copy link
Collaborator Author

htcfreek commented May 24, 2021

This needs to be directly driven by requirements versus hypothetical.

How do you mean this? What do you think how it could work?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-User Interface things that regard UX for PowerToys Idea-Enhancement New feature or request on an existing product Run-Plugin Manager Issues with the PowerToys Run plugin manager
Projects
None yet
Development

No branches or pull requests

2 participants