Fix inconsistency in the color of QueryTextBox #6222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsrivastavv
added
the
Product-PowerToys Run
arjunbalgovind
approved these changes
Aug 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
Fix inconsistency in the color of QueryTextBox
PR Checklist
Info on Pull Request
The color of the QueryTextBox text was different when autocomplete text suggestion was available as show below :
Search text without autocomplete text
Search text with autocomplete text
This issue was happening because of changes made in #6049, where
AutoCompleteTextBlockwas placed on top onQueryTextBoxcausing the lighter color of the former to be visible. This PR makes the following changes to fix this issue.AutoCompleteTextBlockto be strictly less thanQueryTextBox.AutoCompleteTextBlocktoSystemChromeLowand ofQueryTextBoxtotransparent.Validation Steps Performed
Manually validated that color inconsistency is not present in QueryTextBox