Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LWG-2682 filesystem::copy() won't create a symlink to a directory #71

Closed
StephanTLavavej opened this issue Sep 6, 2019 · 1 comment · Fixed by #3827
Closed

LWG-2682 filesystem::copy() won't create a symlink to a directory #71

StephanTLavavej opened this issue Sep 6, 2019 · 1 comment · Fixed by #3827
Labels
filesystem C++17 filesystem fixed Something works now, yay! LWG Library Working Group issue
Milestone
Conformance

Comments

@StephanTLavavej
Copy link
Member

StephanTLavavej commented Sep 6, 2019 •
edited
Loading

LWG-2682 filesystem::copy() won't create a symlink to a directory

Before attempting to implement this, we would like to wait for LWG-3057 "Correct copy_options handling" to be resolved.

Edit: It doesn't seem that LWG-3057 "Correct copy_options handling" will be resolved any time soon. I don't think we need to keep blocking on it.
@StephanTLavavej StephanTLavavej added the LWG Library Working Group issue label Sep 6, 2019
@StephanTLavavej StephanTLavavej changed the title LWG 2682 filesystem::copy() won't create a symlink to a directory LWG-2682 filesystem::copy() won't create a symlink to a directory Oct 23, 2019
@StephanTLavavej StephanTLavavej added the blocked Something is preventing work on this label Oct 23, 2019
@cbezault cbezault added this to the Conformance milestone May 7, 2020
@MahmoudGSaleh MahmoudGSaleh added the filesystem C++17 filesystem label May 4, 2022
@StephanTLavavej StephanTLavavej removed the blocked Something is preventing work on this label Feb 28, 2023
@frederick-vs-ja
Copy link
Contributor

There seems already a branch handling this.

STL/stl/inc/filesystem

Lines 4327 to 4331 in 994f941

if (_STD filesystem::is_directory(_Fstat._Status)) {
if ((_Options & copy_options::create_symlinks) != copy_options::none) {
_Ec = _STD make_error_code(errc::is_a_directory);
return;
}

@frederick-vs-ja frederick-vs-ja mentioned this issue Jun 23, 2023
Merged
@StephanTLavavej StephanTLavavej added the fixed Something works now, yay! label Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
filesystem C++17 filesystem fixed Something works now, yay! LWG Library Working Group issue
Projects
STL LWG Issues
Status: Done
Milestone
Conformance
4 participants
@cbezault @StephanTLavavej @MahmoudGSaleh @frederick-vs-ja