Updated _MSVC_STL_UPDATE to July 2024

[ravixalgorithm]

resolves #4752

[AlexGuteniev]

Hi.

Your PR title is too low-level. The revision and line information can be later fetched from history if neccessary.
Instead, please focus on plain English description on what is done.

Also, the description should mention "resolves #issue", it is not neccessary for the commit itself, but should be in the description.

And you should use the issue number, not the line number,

[ravixalgorithm]

Hi.

Your PR title is too low-level. The revision and line information can be later fetched from history if neccessary. Instead, please focus on plain English description on what is done.

Also, the description should mention "resolves #issue", it is not neccessary for the commit itself, but should be in the description.

And you should use the issue number, not the line number,

Is it Correct now??

[ravixalgorithm]

Can Anyone please review this code pls ..

[AlexGuteniev]

Is it Correct now??

Almost. What you put in the title should go in the description, which is still empty. The title should decribe the change in high level plaintext.

[ravixalgorithm]

Is it Correct now??

Almost. What you put in the title should go in the description, which is still empty. The title should decribe the change in high level plaintext.

I think its now good or can you suggest me a title, I am new to Github I didn't have much knowledge.

[AlexGuteniev]

Thanks. It is now good.

Please wait for a review by some of maintainers.

[StephanTLavavej]

Thanks, this is perfect! 😻

We merge PRs to our GitHub and MSVC-internal repos simultaneously. This is a semi-manual process, so we batch up PRs to save time. Your PR will be part of the next batch, likely this week. I'll post comments here when I'm preparing to mirror your PR, and when I merge it - no further action is necessary on your part. 🎉

[StephanTLavavej]

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

[StephanTLavavej]

I updated your PR description to say "resolves #4752" instead of "resolves issue #4752" - the magic words only work when they're immediately followed by an issue number, and the word "issue" interferes with that.

Thanks for updating this version macro, and congratulations on your first microsoft/STL commit! 🎉 😻 🚀

This will be the value that appears in VS 2022 17.12 Preview 1 when that ships.

[ravixalgorithm]

Thanks, it's an honor

…

On Fri, 5 Jul 2024, 12:34 pm Stephan T. Lavavej, ***@***.***> wrote: I updated your PR description to say "resolves #4752 <#4752>" instead of "resolves issue #4752 <#4752>" - the magic words only work when they're immediately followed by an issue number, and the word "issue" interferes with that. Thanks for updating this version macro, and congratulations on your first microsoft/STL commit! 🎉 😻 🚀 This will be the value that appears in VS 2022 17.12 Preview 1 when that ships. — Reply to this email directly, view it on GitHub <#4754 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/BDOLW6BPAXKXA4ZU5GECNMLZKZAQNAVCNFSM6AAAAABKD5XLYWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMJQGMYTIOBUGA> . You are receiving this because you authored the thread.Message ID: ***@***.***>