Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shebang in js / jsx / tsx is classified as ".ts" #813

Closed
asottile opened this issue Mar 27, 2020 · 1 comment
Closed

shebang in js / jsx / tsx is classified as ".ts" #813

asottile opened this issue Mar 27, 2020 · 1 comment

Comments

@asottile
Copy link

I unfortunately don't have a direct reproduction involving actual code so I've omitted the issue template, this was noticed while auditing the source of the textmate grammars

<dict>
<key>name</key>
<string>comment.line.shebang.ts</string>
<key>match</key>
<string>\A(#!).*(?=$)</string>
<key>captures</key>
<dict>
<key>1</key>
<dict>
<key>name</key>
<string>punctuation.definition.comment.ts</string>
</dict>
</dict>
</dict>

I believe these should be .tsx for the "TypeScriptReact" -- a fix to that will also fix the js / jsx grammars in vs code which do a replace on /\.tsx/ to the destination scope

@asottile
Copy link
Author

awesome, thanks a ton @sheetalkamat 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant