Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Two pages named "Modules" in the handbook #2873

Closed
not-my-profile opened this issue Jul 4, 2023 · 3 comments
Closed

Two pages named "Modules" in the handbook #2873

not-my-profile opened this issue Jul 4, 2023 · 3 comments

Comments

@not-my-profile
Copy link
Contributor

not-my-profile commented Jul 4, 2023

There is the Modules page and then there is the Modules page (note the /2/ in the URL).

#1611 apparently didn't add a deprecated_by frontmatter field for the older page.

Most confusingly the new page still references the old same-named page:

and you can find information about the other module patterns in the reference section under Modules.

If we don't deprecate the older page for the former then I think we should at least rename it (perhaps to Modules (Legacy)), update the backlinks accordingly and add a reference to the newer page to the intro of the older page.

@jakebailey
Copy link
Member

You must have deleted the template. Per #2804, we're not accepting non-critical issues; we'd happily accept a PR which improves things if you have a concrete idea, but otherwise short of the page not actually rendering or being totally broken, I'm going to close this.

@jakebailey jakebailey closed this as not planned Won't fix, can't repro, duplicate, stale Jul 9, 2023
@not-my-profile
Copy link
Contributor Author

No, I didn't delete anything. You still have blank issues enabled, see #2879.

@jakebailey
Copy link
Member

Darn, well, I just assumed nobody would click that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants